all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Suhail Singh <suhailsingh247@gmail.com>
To: "jgart" <jgart@dismail.de>
Cc: 72925@debbugs.gnu.org, "Omar Bassam" <omar.bassam88@gmail.com>,
	"Ludovic Courtès" <ludovic.courtes@inria.fr>,
	"Suhail Singh" <suhailsingh247@gmail.com>
Subject: [bug#72925] Adding JPM package for Janet
Date: Sun, 05 Jan 2025 16:12:24 -0500	[thread overview]
Message-ID: <874j2dt16v.fsf@gmail.com> (raw)
In-Reply-To: <e16f960f310758919876e307a194b5b75dc030c5@dismail.de> (jgart@dismail.de's message of "Sun, 05 Jan 2025 20:14:13 +0000")

"jgart" <jgart@dismail.de> writes:

> I will try to review it next weekend when I free up some time
> hopefully.

Thank you.

> Can the contributor please summarize for me/fill me in on the latest
> version,

Omar submitted the original patch series that spawned the issue.  I
reviewed the patches.  However, at some point it was easier to provide
feedback by submitting a revision myself.  Specifically, v12 was
submitted by me.  Ludo requested some further tweaks.  I was able to
partially address that feedback in v13.  The possibly outstanding point
(which may or may not be a nitpick and may or may not be relevant), is
noted in <https://issues.guix.gnu.org/72925#69>.

> if it is able load janet packages with jpm

Yes.

> and what they have tested that works so far

For v13, given a profile containing only jpm, bash, coreutils-minimal
and nss-certs and loading it using something like the below:

#+begin_src sh
  guix shell --pure -CPWN \
    -E '.*GTK.*|.*XDG.*|.*DISPLAY.*|TERM|INSIDE_EMACS' \
    -p /path/to/profile
#+end_src

I have tested using the below commands:

#+begin_src sh
  cd /tmp
  mkdir -p review-72925 && cd review-72925
  jpm install -l sh
  jpm install -l spork
#+end_src

Based on <https://issues.guix.gnu.org/72925#59>, I believe Omar may have
done some additional testing as well.

-- 
Suhail




  reply	other threads:[~2025-01-05 21:13 UTC|newest]

Thread overview: 89+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-01  8:31 [bug#72925] Adding JPM package for Janet Omar Bassam
2024-09-04  8:22 ` [bug#72925] [PATCH] adding jpm package Omar Bassam
2024-09-05 14:50 ` Omar Bassam
2024-09-18 13:18   ` [bug#72925] Adding JPM package for Janet Suhail Singh
2024-09-18 15:34     ` Omar Bassam
2024-09-18 16:16       ` Suhail Singh
2024-09-30  8:12 ` [bug#72925] [PATCH v3] adding jpm package Omar Bassam
2024-10-01  0:06   ` Suhail Singh
2024-10-02 15:09     ` Omar Bassam
2024-10-02 18:21       ` Suhail Singh
2024-10-02 19:04         ` jgart via Guix-patches via
2024-10-02 20:20           ` Language-specific guides for using "guix shell" (was: [bug#72925] [PATCH v3] adding jpm package) Suhail Singh
2024-10-02 20:32             ` Omar Bassam
2024-10-02 20:47               ` jgart
2024-10-03  3:43               ` Language-specific guides for using "guix shell" indieterminacy
2024-10-03  7:06                 ` Omar Bassam
2024-10-23 16:39             ` Ludovic Courtès
2024-10-02 19:12         ` [bug#72925] [PATCH v3] adding jpm package Omar Bassam
2024-10-02 20:14           ` Suhail Singh
2024-10-02 20:27             ` Omar Bassam
2024-10-02 20:33               ` jgart via Guix-patches via
2024-10-02 21:39               ` Suhail Singh
2024-10-02 21:52                 ` Omar Bassam
2024-10-02 22:07                   ` Suhail Singh
2024-10-03  1:40                     ` Suhail Singh
2024-10-03  7:14                       ` Omar Bassam
2024-10-03 13:40                         ` [bug#72925] Adding JPM package for Janet Suhail Singh
2024-10-03 19:45                           ` Omar Bassam
2024-10-03 22:04                             ` Omar Bassam
2024-10-04 16:00                               ` Omar Bassam
2024-10-05  3:11                                 ` Suhail Singh
2024-10-02 20:27             ` [bug#72925] [PATCH v3] adding jpm package jgart via Guix-patches via
2024-10-02 14:36 ` [bug#72925] [PATCH v5] gnu: add " Omar Bassam
2024-10-02 14:50 ` [bug#72925] [PATCH v6] " Omar Bassam
2024-10-02 14:51 ` [bug#72925] [PATCH v7] " Omar Bassam
2024-10-04 15:17   ` Omar Bassam
2024-10-04 15:57 ` [bug#72925] [PATCH v8] " Omar Bassam
2024-10-05  3:28   ` Suhail Singh
2024-10-05 17:25     ` [bug#72925] Adding JPM package for Janet Suhail Singh
2024-10-05  3:15 ` [bug#72925] [PATCH v9] gnu: Add jpm Suhail Singh
2024-10-05 17:21 ` [bug#72925] [PATCH v10] " Suhail Singh
2024-10-06 13:21   ` Omar Bassam
2024-10-06 15:46     ` Suhail Singh
2024-10-06 19:48       ` Omar Bassam
2024-10-06 21:44         ` Suhail Singh
2024-10-07 18:24           ` Omar Bassam
2024-10-07 18:51             ` Suhail Singh
2024-10-07 19:17               ` Omar Bassam
2024-10-07 20:15                 ` Suhail Singh
2024-10-07 21:13                   ` Omar Bassam
2024-10-08  0:11                     ` Suhail Singh
2024-10-08  3:49                       ` Suhail Singh
2024-10-08  8:25                       ` Omar Bassam
2024-10-08 13:39                         ` Suhail Singh
2024-10-08 16:33                           ` Omar Bassam
2024-10-08 22:01                             ` Suhail Singh
2024-10-09 11:58                               ` Omar Bassam
2024-10-09 13:12                                 ` Suhail Singh
2024-10-09 16:49                                   ` Omar Bassam
2024-10-09 17:15                                     ` Suhail Singh
2024-10-11 16:23                                       ` Omar Bassam
2024-10-11 16:45                                         ` Suhail Singh
2024-10-07 21:08 ` [bug#72925] [PATCH v11] gnu: Add jpm package Omar Bassam
2024-10-08  4:13 ` [bug#72925] [PATCH v12 0/2] " Suhail Singh
2024-10-08  4:14   ` [bug#72925] [PATCH v12 1/2] " Suhail Singh
2024-10-12 17:18     ` [bug#72925] Adding JPM package for Janet Ludovic Courtès
2024-10-12 20:17       ` Suhail Singh
2024-10-08  4:16   ` [bug#72925] [PATCH v12 2/2] gnu: Improve user-experience for jpm Suhail Singh
2024-10-12 17:22     ` [bug#72925] Adding JPM package for Janet Ludovic Courtès
2024-10-12 20:22       ` Suhail Singh
2024-10-12 21:14       ` Suhail Singh
2024-11-05 17:13         ` Suhail Singh
2024-10-14 17:23 ` [bug#72925] [PATCH v13 0/2] Add jpm Suhail Singh
2024-10-14 17:25   ` [bug#72925] [PATCH v13 1/2] gnu: Add jpm package Suhail Singh
2024-10-14 17:26   ` [bug#72925] [PATCH v13 2/2] gnu: Improve user-experience for jpm Suhail Singh
2025-01-05 16:28 ` [bug#72925] Adding JPM package for Janet Omar Bassam
2025-01-05 17:12   ` Suhail Singh
2025-01-05 20:14     ` jgart via Guix-patches via
2025-01-05 21:12       ` Suhail Singh [this message]
2025-01-05 21:22         ` jgart via Guix-patches via
2025-01-05 22:39           ` Suhail Singh
2025-01-05 22:59             ` jgart via Guix-patches via
2025-01-05 23:27               ` Suhail Singh
2025-01-06  1:05                 ` jgart via Guix-patches via
2025-01-06  1:33                   ` Suhail Singh
2025-01-06  2:16                     ` bug#72925: " jgart via Guix-patches via
2025-01-05 22:28 ` [bug#72925] [PATCH v14 0/2] Add jpm Suhail Singh
2024-10-08  3:22   ` [bug#72925] [PATCH v14 2/2] gnu: Improve user-experience for jpm Suhail Singh
2024-10-08  3:31   ` [bug#72925] [PATCH v14 1/2] gnu: Add jpm package Suhail Singh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874j2dt16v.fsf@gmail.com \
    --to=suhailsingh247@gmail.com \
    --cc=72925@debbugs.gnu.org \
    --cc=jgart@dismail.de \
    --cc=ludovic.courtes@inria.fr \
    --cc=omar.bassam88@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.