[bug#75425] [PATCH] gnu: appimage-type2-runtime: Fix cross-compiling.

[bug#75425] [PATCH] gnu: appimage-type2-runtime: Fix cross-compiling.

[Brian Kubisiak]

* gnu/packages/appimage.scm (appimage-type2-runtime)[arguments]<#:make-flags>: Use
CC-FOR-TARGET and add "-Wno-int-conversion".

Change-Id: I5dd9c6cb81e30713f17d474e9a5e11817db7158e
---
 gnu/packages/appimage.scm | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/appimage.scm b/gnu/packages/appimage.scm
index 1d0caada46..620628c053 100644
--- a/gnu/packages/appimage.scm
+++ b/gnu/packages/appimage.scm
@@ -49,11 +49,13 @@ (define-public appimage-type2-runtime
        (list
         #:make-flags
         #~(list "-Csrc/runtime" "runtime-fuse3"
+                (string-append "CC=" #$(cc-for-target))
                 (string-append
                  "CFLAGS=" "-I" #$(this-package-input "fuse") "/include/fuse/"
                  " -DGIT_COMMIT='\"" "guix-" #$version "\"'"
                  " -D_FILE_OFFSET_BITS=64"
-                 " -static"))
+                 " -static"
+                 " -Wno-int-conversion"))
         #:modules
         `((guix build gnu-build-system)
           (guix build utils)

base-commit: a76f2d5927c86e4a76a1d3b49c1a37054612f6c0
prerequisite-patch-id: b7500f0446826469bbf2f858e044cc3e0eae98c5
-- 
2.46.0

[bug#75425] QA review for 75425

[Noé Lopez via Guix-patches via]

user guix
usertag 75425 + reviewed-looks-good
thanks

Guix QA review form submission:
Cross build works for aarch64-linux-gnu and riscv-linux-gnu. I also checked that AppImage packs still work.

Thanks for the patch!

Items marked as checked: Lint warnings, Package builds, Commit messages

bug#75425: [PATCH] gnu: appimage-type2-runtime: Fix cross-compiling.

[Zheng Junjie]

[-- Attachment #1: Type: text/plain, Size: 1341 bytes --]

Brian Kubisiak <brian@kubisiak.com> writes:

> * gnu/packages/appimage.scm (appimage-type2-runtime)[arguments]<#:make-flags>: Use
> CC-FOR-TARGET and add "-Wno-int-conversion".
>
> Change-Id: I5dd9c6cb81e30713f17d474e9a5e11817db7158e
> ---
>  gnu/packages/appimage.scm | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/appimage.scm b/gnu/packages/appimage.scm
> index 1d0caada46..620628c053 100644
> --- a/gnu/packages/appimage.scm
> +++ b/gnu/packages/appimage.scm
> @@ -49,11 +49,13 @@ (define-public appimage-type2-runtime
>         (list
>          #:make-flags
>          #~(list "-Csrc/runtime" "runtime-fuse3"
> +                (string-append "CC=" #$(cc-for-target))
>                  (string-append
>                   "CFLAGS=" "-I" #$(this-package-input "fuse") "/include/fuse/"
>                   " -DGIT_COMMIT='\"" "guix-" #$version "\"'"
>                   " -D_FILE_OFFSET_BITS=64"
> -                 " -static"))
> +                 " -static"
> +                 " -Wno-int-conversion"))
>          #:modules
>          `((guix build gnu-build-system)
>            (guix build utils)
>
> base-commit: a76f2d5927c86e4a76a1d3b49c1a37054612f6c0
> prerequisite-patch-id: b7500f0446826469bbf2f858e044cc3e0eae98c5
pushed, closing.

And fix squashfuse-for-appimage's name, indentation.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]