From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH] distro: Add GNU Wget.
Date: Sun, 25 Nov 2012 16:03:53 +0100
Message-ID: <8738zx7mhy.fsf@gnu.org>
References: <CAD15K4vrZ+C3KYKkvJdLPKTrVod0dd1zS_pa7fi6M30DDcZ2ow@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([208.118.235.92]:57896)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1Tcdkb-0001RA-JU
	for bug-guix@gnu.org; Sun, 25 Nov 2012 10:04:06 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1Tcdka-00026T-PF
	for bug-guix@gnu.org; Sun, 25 Nov 2012 10:04:05 -0500
Received: from [2a01:e0b:1:123:ca0a:a9ff:fe03:271e] (port=45779
	helo=xanadu.aquilenet.fr) by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1Tcdka-000242-JD
	for bug-guix@gnu.org; Sun, 25 Nov 2012 10:04:04 -0500
In-Reply-To: <CAD15K4vrZ+C3KYKkvJdLPKTrVod0dd1zS_pa7fi6M30DDcZ2ow@mail.gmail.com>
	(Nikita Karetnikov's message of "Sun, 25 Nov 2012 05:27:41 +0300")
List-Id: Bug reports for GNU Guix <bug-guix.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-guix>
List-Post: <mailto:bug-guix@gnu.org>
List-Help: <mailto:bug-guix-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=subscribe>
Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org
Sender: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org
To: Nikita Karetnikov <nikita.karetnikov@gmail.com>
Cc: bug-guix@gnu.org

Hi,

Nikita Karetnikov <nikita.karetnikov@gmail.com> skribis:

> (I attached the patch.)

Applied.  I added this line to fix chroot builds:

    (arguments
     '(#:phases
       (alist-cons-before 'build 'patch-/usr/bin/env
                          (lambda _
                            (for-each patch-shebang
                                      '("doc/texi2pod.pl" "tests/run-px")))
                          %standard-phases)))

> I'm getting this warning:
>
> WARNING: (distro packages wget): imported module (distro packages
> gettext) overrides core binding `gettext'
>
> According to this message, [1] there is no need to worry, but I'd like
> to be sure. Could you clarify?

Indeed, it=E2=80=99s just saying that the core =E2=80=98gettext=E2=80=99 bi=
nding is being
overridden by ours within (distro packages wget).

To silence the warning, perhaps we could rename =E2=80=98gettext=E2=80=99 to
=E2=80=98gnu-gettext=E2=80=99, as I did for GNU Make.  WDYT?

> Also, './pre-inst-env guix-import ../nixpkgs-github wget' listed the
> following:
>
> (inputs ...
>   ("perl-libwww-perl" ,perl-libwww-perl))
>
> But it builds fine without this line. Can we omit it?

It=E2=80=99s an optional dependency (a Perl package) used to run some of the
tests.  Currently, we see a lot of these warnings during =E2=80=9Cmake chec=
k=E2=80=9D:

  Can't locate HTTP/Daemon.pm in @INC (@INC contains: ../tests /nix/store/a=
0si4l5cnbdh7ypwnz7k2knfpli8agra-perl-5.16.1/lib/perl5/site_perl/5.16.1/x86_=
64-linux /nix/store/a0si4l5cnbdh7ypwnz7k2knfpli8agra-perl-5.16.1/lib/perl5/=
site_perl/5.16.1 /nix/store/a0si4l5cnbdh7ypwnz7k2knfpli8agra-perl-5.16.1/li=
b/perl5/5.16.1/x86_64-linux /nix/store/a0si4l5cnbdh7ypwnz7k2knfpli8agra-per=
l-5.16.1/lib/perl5/5.16.1 .) at ../tests/HTTPServer.pm line 6.

This is because we lack libwww-perl, I guess.  Something to add
eventually.

Thanks,
Ludo=E2=80=99.