Re: [PATCH] distro: Add GNU Wget.

[ludo@gnu.org (Ludovic Courtès)]

Hi,

Nikita Karetnikov <nikita.karetnikov@gmail.com> skribis:

> (I attached the patch.)

Applied.  I added this line to fix chroot builds:

    (arguments
     '(#:phases
       (alist-cons-before 'build 'patch-/usr/bin/env
                          (lambda _
                            (for-each patch-shebang
                                      '("doc/texi2pod.pl" "tests/run-px")))
                          %standard-phases)))

> I'm getting this warning:
>
> WARNING: (distro packages wget): imported module (distro packages
> gettext) overrides core binding `gettext'
>
> According to this message, [1] there is no need to worry, but I'd like
> to be sure. Could you clarify?

Indeed, it’s just saying that the core ‘gettext’ binding is being
overridden by ours within (distro packages wget).

To silence the warning, perhaps we could rename ‘gettext’ to
‘gnu-gettext’, as I did for GNU Make.  WDYT?

> Also, './pre-inst-env guix-import ../nixpkgs-github wget' listed the
> following:
>
> (inputs ...
>   ("perl-libwww-perl" ,perl-libwww-perl))
>
> But it builds fine without this line. Can we omit it?

It’s an optional dependency (a Perl package) used to run some of the
tests.  Currently, we see a lot of these warnings during “make check”:

  Can't locate HTTP/Daemon.pm in @INC (@INC contains: ../tests /nix/store/a0si4l5cnbdh7ypwnz7k2knfpli8agra-perl-5.16.1/lib/perl5/site_perl/5.16.1/x86_64-linux /nix/store/a0si4l5cnbdh7ypwnz7k2knfpli8agra-perl-5.16.1/lib/perl5/site_perl/5.16.1 /nix/store/a0si4l5cnbdh7ypwnz7k2knfpli8agra-perl-5.16.1/lib/perl5/5.16.1/x86_64-linux /nix/store/a0si4l5cnbdh7ypwnz7k2knfpli8agra-perl-5.16.1/lib/perl5/5.16.1 .) at ../tests/HTTPServer.pm line 6.

This is because we lack libwww-perl, I guess.  Something to add
eventually.

Thanks,
Ludo’.