From: ludo@gnu.org (Ludovic Courtès)
To: Cyril Roelandt <tipecaml@gmail.com>
Cc: bug-guix@gnu.org
Subject: Re: [PATCH] package: allow users to upgrade the whole system by not providing a regexp.
Date: Mon, 15 Apr 2013 23:50:59 +0200 [thread overview]
Message-ID: <8738urihto.fsf@gnu.org> (raw)
In-Reply-To: <1366061251-24354-1-git-send-email-tipecaml@gmail.com> (Cyril Roelandt's message of "Mon, 15 Apr 2013 23:27:31 +0200")
Cyril Roelandt <tipecaml@gmail.com> skribis:
> 'guix package --upgrade' is now the same as "guix package --upgrade=''".
[...]
> - (option '(#\u "upgrade") #t #f
> + (option '(#\u "upgrade") #f #f
Should be #f #t (the first one is ‘required?’, the second one is
‘optional?’, see SRFI-37.)
> @@ -602,7 +602,9 @@ Install, remove, or upgrade PACKAGES in a single transaction.\n"))
> (let* ((installed (manifest-packages (profile-manifest profile)))
> (upgrade-regexps (filter-map (match-lambda
> (('upgrade . regexp)
> - (make-regexp regexp))
> + (if regexp
> + (make-regexp regexp)
> + (make-regexp "")))
Rather: (make-regexp (or regexp "")).
Could you also update the manual?
Thanks!
Ludo’.
next prev parent reply other threads:[~2013-04-15 21:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-15 21:27 [PATCH] package: allow users to upgrade the whole system by not providing a regexp Cyril Roelandt
2013-04-15 21:50 ` Ludovic Courtès [this message]
2013-04-15 22:17 ` Cyril Roelandt
2013-04-16 18:57 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8738urihto.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=bug-guix@gnu.org \
--cc=tipecaml@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.