Re: [PATCH 3/3] gnu: Add mupdf

[ludo@gnu.org (Ludovic Courtès)]

Dušan Xmetov <merkur32@gmail.com> skribis:

> On 9/15/14, Alex Kost <alezost@gmail.com> wrote:
>> 5 * trailing space.
>>
>
> They were generated by diff, won't removing them break the patch?

I’m not sure, and that’s why I think it’s OK to keep trailing spaces in
diffs (and because the tools generate them this way.)

>>
>>> +    (inputs
>>> +      `(("curl" ,curl)
>>> +        ("freetype", freetype)
>>
>> ("freetype" ,freetype)
>>
>
> Yup.
>
>>
>>> +    (synopsis "A lightweight PDF viewer and toolkit.")
>>> +    (description
>>> +      "MuPDF is a C library that implements a PDF and XPS parsing and
>>> rendering
>>> +engine. It is used primarily to render pages into bitmaps, but also
>>> provides
>>> +support for other operations such as searching and listing the table of
>>> +contents and hyperlinks.
>>> +
>>> +The library ships with a rudimentary X11 viewer, and a set of command
>>> line tools
>>> +for batch rendering (pdfdraw), examining the file structure (pdfshow),
>>> and
>>> +rewriting files (pdfclean).")
>>> +    (license license:agpl3+)))
>>
>> I think people usually avoid a period in a synopsis and use a double
>> space after a period in a description.  Also the description should be
>> wrapped by 72 (or 78?) characters in a line.

Indeed.  Actually ‘guix lint mupdf’ would tell you that the synopsis
shouldn’t start with “A” and shouldn’t end with a period.

Thanks in advance!

Ludo’.