From mboxrd@z Thu Jan  1 00:00:00 1970
From: =?utf-8?B?5a6L5paH5q2m?= <iyzsong@gmail.com>
Subject: Re: [PATCH] gnu: Add ninja.
Date: Sat, 10 Jan 2015 19:07:29 +0800
Message-ID: <87387i99n2.fsf@gmail.com>
References: <1420810817-23613-1-git-send-email-iyzsong@gmail.com>
	<87fvbk3tvy.fsf@gnu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:56929)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <iyzsong@gmail.com>) id 1Y9ttE-0007bL-0B
	for guix-devel@gnu.org; Sat, 10 Jan 2015 06:07:32 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <iyzsong@gmail.com>) id 1Y9ttC-0005X9-4l
	for guix-devel@gnu.org; Sat, 10 Jan 2015 06:07:31 -0500
In-Reply-To: <87fvbk3tvy.fsf@gnu.org>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Ludovic =?utf-8?Q?Court=C3=A8s?= <ludo@gnu.org>
Cc: guix-devel@gnu.org

Ludovic Court=C3=A8s <ludo@gnu.org> writes:

> =E5=AE=8B=E6=96=87=E6=AD=A6 <iyzsong@gmail.com> skribis:
>
>> * gnu/packages/ninja.scm: New file.
>> * gnu-system.am (GNU_SYSTEM_MODULES): Add it.
>
> [...]
>
>> +          'check
>> +          (lambda _
>> +            (and (zero? (system "./configure.py"))
>> +                 (zero? (system "./ninja ninja_test"))
>> +                 ;; SubprocessTest.InterruptChild fail when using 'syst=
em*'.
>> +                 ;; SubprocessTest.SetWithLots was skipped.
>> +                 ;; XXX: Raise [ulimit -n] well above 1025 to make this=
 test go.
>
> Does it mean that the test is currently failing?
Yes, SetWithLots fail with the 'Raise ...' line.
>
>> +                 (zero? (system (string-append
>> +                                 "./ninja_test "
>> +                                 "--gtest_filter=3D"
>> +                                 "-SubprocessTest.SetWithLots")))))
>
> Please use =E2=80=98system*=E2=80=99 (with separate arguments) rather tha=
n =E2=80=98system=E2=80=99.
> The latter runs =E2=80=9C/bin/sh -c ...=E2=80=9D whereas the former runs =
the program
> directly.
Use 'system*' to run "./ninja_test" will cause InterruptChild to fail :(
(as I mentioned in the comment)
>
> Thanks,
> Ludo=E2=80=99.