From: 宋文武 <iyzsong@gmail.com>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] gnu: Add ninja.
Date: Sat, 10 Jan 2015 19:07:29 +0800 [thread overview]
Message-ID: <87387i99n2.fsf@gmail.com> (raw)
In-Reply-To: <87fvbk3tvy.fsf@gnu.org>
Ludovic Courtès <ludo@gnu.org> writes:
> 宋文武 <iyzsong@gmail.com> skribis:
>
>> * gnu/packages/ninja.scm: New file.
>> * gnu-system.am (GNU_SYSTEM_MODULES): Add it.
>
> [...]
>
>> + 'check
>> + (lambda _
>> + (and (zero? (system "./configure.py"))
>> + (zero? (system "./ninja ninja_test"))
>> + ;; SubprocessTest.InterruptChild fail when using 'system*'.
>> + ;; SubprocessTest.SetWithLots was skipped.
>> + ;; XXX: Raise [ulimit -n] well above 1025 to make this test go.
>
> Does it mean that the test is currently failing?
Yes, SetWithLots fail with the 'Raise ...' line.
>
>> + (zero? (system (string-append
>> + "./ninja_test "
>> + "--gtest_filter="
>> + "-SubprocessTest.SetWithLots")))))
>
> Please use ‘system*’ (with separate arguments) rather than ‘system’.
> The latter runs “/bin/sh -c ...” whereas the former runs the program
> directly.
Use 'system*' to run "./ninja_test" will cause InterruptChild to fail :(
(as I mentioned in the comment)
>
> Thanks,
> Ludo’.
next prev parent reply other threads:[~2015-01-10 11:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-09 13:40 [PATCH] gnu: Add ninja 宋文武
2015-01-09 14:34 ` Ludovic Courtès
2015-01-10 11:07 ` 宋文武 [this message]
2015-01-10 13:46 ` Ludovic Courtès
2015-01-11 3:07 ` 宋文武
2015-01-11 10:53 ` Ludovic Courtès
2015-01-11 11:28 ` 宋文武
2015-01-12 9:53 ` Ludovic Courtès
2015-01-14 0:31 ` Mark H Weaver
2015-01-15 11:15 ` 宋文武
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87387i99n2.fsf@gmail.com \
--to=iyzsong@gmail.com \
--cc=guix-devel@gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.