From: David Thompson <dthompson2@worcester.edu>
To: "Taylan Ulrich Bayırlı/Kammer" <taylanbayirli@gmail.com>,
guix-devel@gnu.org
Subject: Re: [PATCH] gnu: Add moreutils.
Date: Sat, 31 Jan 2015 20:44:50 -0500 [thread overview]
Message-ID: <87386ql819.fsf@izanagi.i-did-not-set--mail-host-address--so-tickle-me> (raw)
In-Reply-To: <87a90yqvb6.fsf@taylan.uni.cx>
"Taylan Ulrich Bayırlı/Kammer" <taylanbayirli@gmail.com> writes:
> From c770ed88c66c10de47e8fe7f84c3df6cf7b14aa4 Mon Sep 17 00:00:00 2001
> From: =?UTF-8?q?Taylan=20Ulrich=20Bay=C4=B1rl=C4=B1/Kammer?=
> <taylanbayirli@gmail.com>
> Date: Sun, 1 Feb 2015 02:21:11 +0100
> Subject: [PATCH] gnu: Add moreutils.
>
> * gnu-system.am (GNU_SYSTEM_MODULES): Add moreutils.scm.
> * gnu/packages/moreutils.scm: New file.
> ---
> gnu-system.am | 1 +
> gnu/packages/moreutils.scm | 71 ++++++++++++++++++++++++++++++++++++++++++++++
> 2 files changed, 72 insertions(+)
> create mode 100644 gnu/packages/moreutils.scm
>
> diff --git a/gnu-system.am b/gnu-system.am
> index 706ad57..8ae5b79 100644
> --- a/gnu-system.am
> +++ b/gnu-system.am
> @@ -187,6 +187,7 @@ GNU_SYSTEM_MODULES = \
> gnu/packages/miscfiles.scm \
> gnu/packages/mit-krb5.scm \
> gnu/packages/moe.scm \
> + gnu/packages/moreutils.scm \
> gnu/packages/mpd.scm \
> gnu/packages/mp3.scm \
> gnu/packages/mpi.scm \
> diff --git a/gnu/packages/moreutils.scm b/gnu/packages/moreutils.scm
> new file mode 100644
> index 0000000..da3df89
> --- /dev/null
> +++ b/gnu/packages/moreutils.scm
> @@ -0,0 +1,71 @@
> +;;; GNU Guix --- Functional package management for GNU
> +;;; Copyright © 2014 Taylan Ulrich Bayırlı/Kammer <taylanbayirli@gmail.com>
> +;;;
> +;;; This file is part of GNU Guix.
> +;;;
> +;;; GNU Guix is free software; you can redistribute it and/or modify it
> +;;; under the terms of the GNU General Public License as published by
> +;;; the Free Software Foundation; either version 3 of the License, or (at
> +;;; your option) any later version.
> +;;;
> +;;; GNU Guix is distributed in the hope that it will be useful, but
> +;;; WITHOUT ANY WARRANTY; without even the implied warranty of
> +;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> +;;; GNU General Public License for more details.
> +;;;
> +;;; You should have received a copy of the GNU General Public License
> +;;; along with GNU Guix. If not, see <http://www.gnu.org/licenses/>.
> +
> +(define-module (gnu packages moreutils)
> + #:use-module ((guix licenses) #:prefix l:)
> + #:use-module (guix packages)
> + #:use-module (guix download)
> + #:use-module (guix build-system gnu)
> + #:use-module (gnu packages perl)
> + #:use-module (gnu packages xml)
> + #:use-module (gnu packages docbook))
> +
> +(define-public moreutils
> + (package
> + (name "moreutils")
> + (version "0.55")
> + (source (origin
> + (method url-fetch)
> + (uri (string-append
> + "http://ftp.debian.org/debian/pool/main/m/moreutils/moreutils_"
> + version ".orig.tar.gz"))
> + (sha256
> + (base32
> + "1dcah2jx8dbznn8966xl7sf1jrld2qfh6l6xcmx9dsnf8p8mr7fs"))))
> + (build-system gnu-build-system)
> + (inputs `(("perl" ,perl)
> + ("libxml2" ,libxml2)
> + ("libxslt" ,libxslt)
> + ("docbook-xml" ,docbook-xml-4.4)
> + ("docbook-xsl" ,docbook-xsl)))
> + (arguments
> + `(#:phases
> + (alist-replace
> + 'configure
> + (lambda* (#:key inputs outputs #:allow-other-keys)
> + (let ((out (assoc-ref outputs "out"))
> + (docbook-xml (assoc-ref inputs "docbook-xml"))
> + (docbook-xsl (assoc-ref inputs "docbook-xsl")))
> + (substitute* "Makefile"
> + (("PREFIX\\?=/usr")
> + (string-append "PREFIX?=" out))
In GNU Make, the '?=' operator for variable assignment means "assign if
the variable isn't already defined"[1]. So, rather than a substitution,
how about just setting an environment variable?
(setenv "PREFIX" out)
> + (("/usr/share/xml/.*/docbook.xsl")
> + (string-append
> + docbook-xsl
> + "/xml/xsl/docbook-xsl-1.78.1/manpages/docbook.xsl")))
> + (setenv
> + "XML_CATALOG_FILES"
> + (string-append docbook-xml "/xml/dtd/docbook/catalog.xml"))
> + (setenv "CC" "gcc")))
> + %standard-phases)))
> + (home-page "http://joeyh.name/code/moreutils/")
> + (synopsis "Miscellaneous general-purpose command-line tools")
> + (description
> + "Moreutils is a collection of general-purpose command-line tools to
> +augment the traditional Unix toolbox.")
> + (license l:gpl2+)))
> --
> 2.2.1
>
>
Everything else looks good to me! :)
[1] https://www.gnu.org/software/make/manual/html_node/Flavors.html#Flavors
--
David Thompson
Web Developer - Free Software Foundation - http://fsf.org
GPG Key: 0FF1D807
Support the FSF: https://fsf.org/donate
next prev parent reply other threads:[~2015-02-01 1:44 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-01 1:23 [PATCH] gnu: Add moreutils Taylan Ulrich Bayırlı/Kammer
2015-02-01 1:44 ` David Thompson [this message]
2015-02-01 5:48 ` Mark H Weaver
2015-02-01 13:08 ` Taylan Ulrich Bayırlı/Kammer
2015-02-01 13:11 ` Taylan Ulrich Bayırlı/Kammer
2015-02-01 14:14 ` David Thompson
2015-02-01 14:51 ` Taylan Ulrich Bayırlı/Kammer
2015-02-01 22:01 ` Mark H Weaver
2015-02-01 22:08 ` docbook-xsl version number in pathname (was Re: [PATCH] gnu: Add moreutils.) Mark H Weaver
2015-02-02 0:16 ` Taylan Ulrich Bayırlı/Kammer
2015-02-13 15:10 ` Mark H Weaver
2015-02-02 21:51 ` [PATCH] gnu: Add moreutils Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87386ql819.fsf@izanagi.i-did-not-set--mail-host-address--so-tickle-me \
--to=dthompson2@worcester.edu \
--cc=guix-devel@gnu.org \
--cc=taylanbayirli@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.