From mboxrd@z Thu Jan 1 00:00:00 1970 From: taylanbayirli@gmail.com (Taylan Ulrich =?utf-8?Q?Bay=C4=B1rl=C4=B1?= =?utf-8?Q?=2FKammer?=) Subject: Re: [PATCH] gnu: Add twolame. Date: Sun, 22 Feb 2015 13:18:25 +0100 Message-ID: <87385y87hq.fsf@taylan.uni.cx> References: <87vbiukfvc.fsf@taylan.uni.cx> <20150222105800.GA29289@debian> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:35241) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YPVUT-00086Z-M1 for guix-devel@gnu.org; Sun, 22 Feb 2015 07:18:30 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YPVUS-0002rH-RH for guix-devel@gnu.org; Sun, 22 Feb 2015 07:18:29 -0500 Received: from mail-wi0-x22a.google.com ([2a00:1450:400c:c05::22a]:59377) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YPVUS-0002r9-LC for guix-devel@gnu.org; Sun, 22 Feb 2015 07:18:28 -0500 Received: by mail-wi0-f170.google.com with SMTP id hi2so14310892wib.1 for ; Sun, 22 Feb 2015 04:18:28 -0800 (PST) In-Reply-To: <20150222105800.GA29289@debian> (Andreas Enge's message of "Sun, 22 Feb 2015 11:58:00 +0100") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Andreas Enge Cc: guix-devel@gnu.org Andreas Enge writes: >> + ("which" ,which))) > > What is this needed for? Maybe add a little comment as it is rather > unusual. I noticed that occasionally some ./configure scripts will say "which: command not found" and in that case I add it. I didn't look into what difference it makes though, since it doesn't make the configure script fail. Is it normal; can one leave it out? > Otherwise it looks good. There is at least one package, ffmpeg, that > can take twolame as an additional input (see the comments in the > package); maybe there are others. It would be nice if, once twolame > pushed, you could hunt them down and adapt them. OK, will look into it. Taylan