From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH]: add freepats and timidity
Date: Tue, 24 Feb 2015 23:17:21 +0100
Message-ID: <87385v9cpa.fsf@gnu.org>
References: <87h9uhlpig.fsf@mango.localdomain> <20150219200320.GA7712@debian>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:55719)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1YQNnK-0004qy-5V
	for guix-devel@gnu.org; Tue, 24 Feb 2015 17:17:35 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1YQNnG-0007sy-6c
	for guix-devel@gnu.org; Tue, 24 Feb 2015 17:17:34 -0500
Received: from fencepost.gnu.org ([2001:4830:134:3::e]:40720)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <ludo@gnu.org>)
	id 1YQNnG-0007sp-48
	for guix-devel@gnu.org; Tue, 24 Feb 2015 17:17:30 -0500
In-Reply-To: <20150219200320.GA7712@debian> (Andreas Enge's message of "Thu,
	19 Feb 2015 21:03:20 +0100")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Andreas Enge <andreas@enge.fr>
Cc: Guix-devel <guix-devel@gnu.org>

Andreas Enge <andreas@enge.fr> skribis:

> On Thu, Feb 19, 2015 at 07:33:59PM +0100, Ricardo Wurmus wrote:
>> +(define-public timidity++
>> +  (package
>> +    (name "timidity++")
>
> Back to names... I would call this "timidity". The package guidelines only
> state that underscores are replaced by "-", but the general idea would be
> to replace special characters with dashes, and to rather drop them at the=
 end
> (or beginning) of a package name.

I=E2=80=99m fine with =E2=80=98timidity++=E2=80=99.

>> +          (let ((out (string-append (assoc-ref %outputs "out")
>> +                                    "/share/timidity")))
>> +            (mkdir-p out)
>> +            (call-with-output-file
>> +                (string-append out "/timidity.cfg")
>
> It is a bit strange to have config files in /share and not in /etc, but t=
hat
> is indeed where by default timidity looks for its config file. Neverthele=
ss,
> I would use
>   (string-append (assoc-ref %outputs "out") "/etc/timidity")
> and then add the configure flag
>   (string-append "--with-default-path=3D" (assoc-ref %outputs "out") "/et=
c/timidity")

Agreed, using $out/etc seems best.

Thanks,
Ludo=E2=80=99.