Re: [PATCH]: add freepats and timidity

[ludo@gnu.org (Ludovic Courtès)]

Andreas Enge <andreas@enge.fr> skribis:

> On Thu, Feb 19, 2015 at 07:33:59PM +0100, Ricardo Wurmus wrote:
>> +(define-public timidity++
>> +  (package
>> +    (name "timidity++")
>
> Back to names... I would call this "timidity". The package guidelines only
> state that underscores are replaced by "-", but the general idea would be
> to replace special characters with dashes, and to rather drop them at the end
> (or beginning) of a package name.

I’m fine with ‘timidity++’.

>> +          (let ((out (string-append (assoc-ref %outputs "out")
>> +                                    "/share/timidity")))
>> +            (mkdir-p out)
>> +            (call-with-output-file
>> +                (string-append out "/timidity.cfg")
>
> It is a bit strange to have config files in /share and not in /etc, but that
> is indeed where by default timidity looks for its config file. Nevertheless,
> I would use
>   (string-append (assoc-ref %outputs "out") "/etc/timidity")
> and then add the configure flag
>   (string-append "--with-default-path=" (assoc-ref %outputs "out") "/etc/timidity")

Agreed, using $out/etc seems best.

Thanks,
Ludo’.