[PATCH] gnu: Add xbindkeys

[PATCH] gnu: Add xbindkeys

[Mathieu Lirzin]

[-- Attachment #1: Type: text/plain, Size: 298 bytes --]

Hi Guix,

Here is a patch adding XBindKeys. When building everything was
fine except one configure warning:

> configure: WARNING: unrecognized options: --enable-fast-install
> phase `configure' succeeded after 6 seconds

Does this require any change in the package definition?

--
Mathieu Lirzin


[-- Attachment #2: 0001-gnu-Add-xbindkeys.patch --]
[-- Type: text/x-diff, Size: 2666 bytes --]

From 9575b2143ea761a2425e53ae227d3ade37c7c128 Mon Sep 17 00:00:00 2001
From: Mathieu Lirzin <mthl@openmailbox.org>
Date: Sun, 1 Mar 2015 14:12:41 +0100
Subject: [PATCH] gnu: Add xbindkeys

* gnu/packages/xdisorg.scm (xbindkeys): New variable.
---
 gnu/packages/xdisorg.scm | 33 +++++++++++++++++++++++++++++++++
 1 file changed, 33 insertions(+)

diff --git a/gnu/packages/xdisorg.scm b/gnu/packages/xdisorg.scm
index d0c983d..2ba6d0b 100644
--- a/gnu/packages/xdisorg.scm
+++ b/gnu/packages/xdisorg.scm
@@ -4,6 +4,7 @@
 ;;; Copyright © 2014 Eric Bavier <bavier@member.fsf.org>
 ;;; Copyright © 2014, 2015 Alex Kost <alezost@gmail.com>
 ;;; Copyright © 2013, 2015 Ludovic Courtès <ludo@gnu.org>
+;;; Copyright © 2015 Mathieu Lirzin <mthl@openmailbox.org>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -32,6 +33,7 @@
   #:use-module (gnu packages glib)
   #:use-module (gnu packages perl)
   #:use-module (gnu packages linux)
+  #:use-module (gnu packages guile)
   #:use-module (gnu packages xorg))
 
 ;; packages outside the x.org system proper
@@ -420,3 +422,34 @@ X Window System.")
      "XOSD provides a C library and a simple utility (osd_cat) for displaying
 transparent text on your screen.")
     (license license:gpl2+)))
+
+(define-public xbindkeys
+  (package
+    (name "xbindkeys")
+    (version "1.8.6")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append
+                    "http://www.nongnu.org/xbindkeys/xbindkeys-"
+                    version
+                    ".tar.gz"))
+              ;; Download from the savannah mirror list fails
+              (sha256
+               (base32
+                "060df6d8y727jp1inp7blp44cs8a7jig7vcm8ndsn6gw36z1h3bc"))))
+    (build-system gnu-build-system)
+    (inputs
+     `(("libx11" ,libx11)
+       ("guile" ,guile-2.0)))
+    (home-page "http://www.nongnu.org/xbindkeys/")
+    (synopsis "Associate a combination of keys with a shell command")
+    (description
+     "XBindKeys is a program that allows you to launch shell commands with
+your keyboard or your mouse under the X Window System.  It links commands to
+keys or mouse buttons, using a configuration file.  It's independent of the
+window manager and can capture all keyboard keys (ex: Power, Wake...).  It
+optionally supports a guile-based configuration file layout, which enables you
+to access all XBindKeys internals, so you can have key combinations, double
+clicks or timed double clicks take actions.  Also all functions that work in
+guile will work for XBindKeys.")
+    (license license:gpl2+)))
-- 
2.1.4

Re: [PATCH] gnu: Add xbindkeys

[David Thompson]

Mathieu Lirzin <mthl@openmailbox.org> writes:

> Here is a patch adding XBindKeys. When building everything was
> fine except one configure warning:
>
>> configure: WARNING: unrecognized options: --enable-fast-install
>> phase `configure' succeeded after 6 seconds
>
> Does this require any change in the package definition?

No.  It's benign.

A few minor comments below:

>
> From 9575b2143ea761a2425e53ae227d3ade37c7c128 Mon Sep 17 00:00:00 2001
> From: Mathieu Lirzin <mthl@openmailbox.org>
> Date: Sun, 1 Mar 2015 14:12:41 +0100
> Subject: [PATCH] gnu: Add xbindkeys
>
> * gnu/packages/xdisorg.scm (xbindkeys): New variable.
> ---
>  gnu/packages/xdisorg.scm | 33 +++++++++++++++++++++++++++++++++
>  1 file changed, 33 insertions(+)
>
> diff --git a/gnu/packages/xdisorg.scm b/gnu/packages/xdisorg.scm
> index d0c983d..2ba6d0b 100644
> --- a/gnu/packages/xdisorg.scm
> +++ b/gnu/packages/xdisorg.scm
> @@ -4,6 +4,7 @@
>  ;;; Copyright © 2014 Eric Bavier <bavier@member.fsf.org>
>  ;;; Copyright © 2014, 2015 Alex Kost <alezost@gmail.com>
>  ;;; Copyright © 2013, 2015 Ludovic Courtès <ludo@gnu.org>
> +;;; Copyright © 2015 Mathieu Lirzin <mthl@openmailbox.org>
>  ;;;
>  ;;; This file is part of GNU Guix.
>  ;;;
> @@ -32,6 +33,7 @@
>    #:use-module (gnu packages glib)
>    #:use-module (gnu packages perl)
>    #:use-module (gnu packages linux)
> +  #:use-module (gnu packages guile)
>    #:use-module (gnu packages xorg))
>  
>  ;; packages outside the x.org system proper
> @@ -420,3 +422,34 @@ X Window System.")
>       "XOSD provides a C library and a simple utility (osd_cat) for displaying
>  transparent text on your screen.")
>      (license license:gpl2+)))
> +
> +(define-public xbindkeys
> +  (package
> +    (name "xbindkeys")
> +    (version "1.8.6")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append
> +                    "http://www.nongnu.org/xbindkeys/xbindkeys-"
> +                    version
> +                    ".tar.gz"))
> +              ;; Download from the savannah mirror list fails

Move this comment above the 'uri' field.

> +              (sha256
> +               (base32
> +                "060df6d8y727jp1inp7blp44cs8a7jig7vcm8ndsn6gw36z1h3bc"))))
> +    (build-system gnu-build-system)
> +    (inputs
> +     `(("libx11" ,libx11)
> +       ("guile" ,guile-2.0)))

Ooh, it's extensible with Guile! :)

> +    (home-page "http://www.nongnu.org/xbindkeys/")
> +    (synopsis "Associate a combination of keys with a shell command")
> +    (description
> +     "XBindKeys is a program that allows you to launch shell commands with
> +your keyboard or your mouse under the X Window System.  It links commands to
> +keys or mouse buttons, using a configuration file.  It's independent of the
> +window manager and can capture all keyboard keys (ex: Power, Wake...).  It
> +optionally supports a guile-based configuration file layout, which enables you
> +to access all XBindKeys internals, so you can have key combinations, double
> +clicks or timed double clicks take actions.  Also all functions that work in
> +guile will work for XBindKeys.")

Capitalize "guile" where it appears.

> +    (license license:gpl2+)))
> -- 
> 2.1.4
>

Looking good, thanks!

-- 
David Thompson
Web Developer - Free Software Foundation - http://fsf.org
GPG Key: 0FF1D807
Support the FSF: https://fsf.org/donate

Re: [PATCH] gnu: Add xbindkeys

[Mathieu Lirzin]

[-- Attachment #1: Type: text/plain, Size: 77 bytes --]

Thanks for your review David, here is the updated patch.

--
Mathieu Lirzin


[-- Attachment #2: 0001-gnu-Add-xbindkeys.patch --]
[-- Type: text/x-diff, Size: 2666 bytes --]

From eaa6fa42811fb5a5e6ce69f9c7a83b891d1c160d Mon Sep 17 00:00:00 2001
From: Mathieu Lirzin <mthl@openmailbox.org>
Date: Sun, 1 Mar 2015 14:12:41 +0100
Subject: [PATCH] gnu: Add xbindkeys

* gnu/packages/xdisorg.scm (xbindkeys): New variable.
---
 gnu/packages/xdisorg.scm | 33 +++++++++++++++++++++++++++++++++
 1 file changed, 33 insertions(+)

diff --git a/gnu/packages/xdisorg.scm b/gnu/packages/xdisorg.scm
index d0c983d..67aa34a 100644
--- a/gnu/packages/xdisorg.scm
+++ b/gnu/packages/xdisorg.scm
@@ -4,6 +4,7 @@
 ;;; Copyright © 2014 Eric Bavier <bavier@member.fsf.org>
 ;;; Copyright © 2014, 2015 Alex Kost <alezost@gmail.com>
 ;;; Copyright © 2013, 2015 Ludovic Courtès <ludo@gnu.org>
+;;; Copyright © 2015 Mathieu Lirzin <mthl@openmailbox.org>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -32,6 +33,7 @@
   #:use-module (gnu packages glib)
   #:use-module (gnu packages perl)
   #:use-module (gnu packages linux)
+  #:use-module (gnu packages guile)
   #:use-module (gnu packages xorg))
 
 ;; packages outside the x.org system proper
@@ -420,3 +422,34 @@ X Window System.")
      "XOSD provides a C library and a simple utility (osd_cat) for displaying
 transparent text on your screen.")
     (license license:gpl2+)))
+
+(define-public xbindkeys
+  (package
+    (name "xbindkeys")
+    (version "1.8.6")
+    (source (origin
+              (method url-fetch)
+              ;; Download from the savannah mirror list fails
+              (uri (string-append
+                    "http://www.nongnu.org/xbindkeys/xbindkeys-"
+                    version
+                    ".tar.gz"))
+              (sha256
+               (base32
+                "060df6d8y727jp1inp7blp44cs8a7jig7vcm8ndsn6gw36z1h3bc"))))
+    (build-system gnu-build-system)
+    (inputs
+     `(("libx11" ,libx11)
+       ("guile" ,guile-2.0)))
+    (home-page "http://www.nongnu.org/xbindkeys/")
+    (synopsis "Associate a combination of keys with a shell command")
+    (description
+     "XBindKeys is a program that allows you to launch shell commands with
+your keyboard or your mouse under the X Window System.  It links commands to
+keys or mouse buttons, using a configuration file.  It's independent of the
+window manager and can capture all keyboard keys (ex: Power, Wake...).  It
+optionally supports a Guile-based configuration file layout, which enables you
+to access all XBindKeys internals, so you can have key combinations, double
+clicks or timed double clicks take actions.  Also all functions that work in
+Guile will work for XBindKeys.")
+    (license license:gpl2+)))
-- 
2.1.4

Re: [PATCH] gnu: Add xbindkeys

[David Thompson]

Mathieu Lirzin <mathieu.lirzin@openmailbox.org> writes:

> Thanks for your review David, here is the updated patch.

Looks good!  I just added a period to the end of the commit log and
pushed.

Thanks!

-- 
David Thompson
Web Developer - Free Software Foundation - http://fsf.org
GPG Key: 0FF1D807
Support the FSF: https://fsf.org/donate