From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: Re: [PATCH] gnu: Add audacity. Date: Wed, 04 Mar 2015 10:48:13 +0100 Message-ID: <87385lm6ua.fsf@gnu.org> References: <87mw46kdkq.fsf@taylan.uni.cx> <87sidrpcm3.fsf@gnu.org> <871tl6fcpy.fsf@taylan.uni.cx> <87zj7trf56.fsf@gnu.org> <87sidlemnx.fsf@taylan.uni.cx> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:44651) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YT5ue-00088u-3j for guix-devel@gnu.org; Wed, 04 Mar 2015 04:48:21 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YT5ua-0001VV-UJ for guix-devel@gnu.org; Wed, 04 Mar 2015 04:48:20 -0500 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:54067) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YT5ua-0001VR-RD for guix-devel@gnu.org; Wed, 04 Mar 2015 04:48:16 -0500 In-Reply-To: <87sidlemnx.fsf@taylan.uni.cx> ("Taylan Ulrich \=\?utf-8\?Q\?\=5C\=22Bay\=C4\=B1rl\=C4\=B1\=2FKammer\=5C\=22\=22's\?\= message of "Tue, 03 Mar 2015 23:33:38 +0100") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Taylan Ulrich =?utf-8?Q?=22Bay=C4=B1rl=C4=B1?= =?utf-8?Q?=2FKammer=22?= Cc: guix-devel@gnu.org taylanbayirli@gmail.com (Taylan Ulrich "Bay=C4=B1rl=C4=B1/Kammer") skribis: > ludo@gnu.org (Ludovic Court=C3=A8s) writes: [...] >> If Audacity uses Autoconf and pkg.m4, I guess you could just pass >> PKG_CONFIG=3Dtrue as a configure flag, or {LIBID3TAG,LIBMAD}_{CFLAGS,LIB= S} >> and it will just work. > > The latter option seems to work. (I suppose the former was meant to be > "PKG_CONFIG=3Dfalse"? That seems to break the whole library search.) I mean =E2=80=98true=E2=80=99 but there were chances of breakage as you not= iced. >>> Note also it's in audacity.scm now and not audio.scm, because it depends >>> on ffmpeg, which is in video.scm, which now imports audio.scm, so >>> audio.scm cannot import video.scm. >> >> It actually can, but it=E2=80=99s fine (and safer) the way you propose. = :-) > > Does Guile support circular imports? (video.scm imports audio.scm on > the meanwhile, in case I wasn't clear about that, so I think we'll have > to avoid importing video.scm from audio.scm.) Modules A and B can import each other iff: 1. no top-level expressions from one module refer to bindings of the other module; 2. neither A nor B #:selects bindings from the other. > From 9d3ae472c1c31400753bfe89ef5d612ba6998cab Mon Sep 17 00:00:00 2001 > From: =3D?UTF-8?q?Taylan=3D20Ulrich=3D20Bay=3DC4=3DB1rl=3DC4=3DB1/Kammer?= =3D > > Date: Mon, 2 Mar 2015 01:06:35 +0100 > Subject: [PATCH 1/2] gnu: portaudio: Patch for Audacity compatibility. > > * gnu/packages/audio.scm (portaudio): Add a patch for Audacity compatibil= ity. > * gnu/packages/patches/portaudio-audacity-compat.patch: New file. > * gnu-system.am (dist_patch_DATA): Add it. OK. > From 0fd1fcb065342aae81411dc62ca78fb0bc7e3afb Mon Sep 17 00:00:00 2001 > From: =3D?UTF-8?q?Taylan=3D20Ulrich=3D20Bay=3DC4=3DB1rl=3DC4=3DB1/Kammer?= =3D > > Date: Fri, 20 Feb 2015 21:52:21 +0100 > Subject: [PATCH 2/2] gnu: Add audacity. > > * gnu/packages/audacity.scm: New file. > * gnu-system.am (GNU_SYSTEM_MODULES): Add it. > * gnu/packages/patches/audacity-fix-ffmpeg-binding.patch: New file. > * gnu-system.am (dist_patch_DATA): Add it. OK as well. Thank you! Ludo=E2=80=99.