Re: [PATCH] gnu: Add audacity.

[ludo@gnu.org (Ludovic Courtès)]

taylanbayirli@gmail.com (Taylan Ulrich "Bayırlı/Kammer") skribis:

> ludo@gnu.org (Ludovic Courtès) writes:

[...]

>> If Audacity uses Autoconf and pkg.m4, I guess you could just pass
>> PKG_CONFIG=true as a configure flag, or {LIBID3TAG,LIBMAD}_{CFLAGS,LIBS}
>> and it will just work.
>
> The latter option seems to work.  (I suppose the former was meant to be
> "PKG_CONFIG=false"?  That seems to break the whole library search.)

I mean ‘true’ but there were chances of breakage as you noticed.

>>> Note also it's in audacity.scm now and not audio.scm, because it depends
>>> on ffmpeg, which is in video.scm, which now imports audio.scm, so
>>> audio.scm cannot import video.scm.
>>
>> It actually can, but it’s fine (and safer) the way you propose.  :-)
>
> Does Guile support circular imports?  (video.scm imports audio.scm on
> the meanwhile, in case I wasn't clear about that, so I think we'll have
> to avoid importing video.scm from audio.scm.)

Modules A and B can import each other iff:

  1. no top-level expressions from one module refer to bindings of the
     other module;

  2. neither A nor B #:selects bindings from the other.

> From 9d3ae472c1c31400753bfe89ef5d612ba6998cab Mon Sep 17 00:00:00 2001
> From: =?UTF-8?q?Taylan=20Ulrich=20Bay=C4=B1rl=C4=B1/Kammer?=
>  <taylanbayirli@gmail.com>
> Date: Mon, 2 Mar 2015 01:06:35 +0100
> Subject: [PATCH 1/2] gnu: portaudio: Patch for Audacity compatibility.
>
> * gnu/packages/audio.scm (portaudio): Add a patch for Audacity compatibility.
> * gnu/packages/patches/portaudio-audacity-compat.patch: New file.
> * gnu-system.am (dist_patch_DATA): Add it.

OK.

> From 0fd1fcb065342aae81411dc62ca78fb0bc7e3afb Mon Sep 17 00:00:00 2001
> From: =?UTF-8?q?Taylan=20Ulrich=20Bay=C4=B1rl=C4=B1/Kammer?=
>  <taylanbayirli@gmail.com>
> Date: Fri, 20 Feb 2015 21:52:21 +0100
> Subject: [PATCH 2/2] gnu: Add audacity.
>
> * gnu/packages/audacity.scm: New file.
> * gnu-system.am (GNU_SYSTEM_MODULES): Add it.
> * gnu/packages/patches/audacity-fix-ffmpeg-binding.patch: New file.
> * gnu-system.am (dist_patch_DATA): Add it.

OK as well.

Thank you!

Ludo’.