From: ludo@gnu.org (Ludovic Courtès)
To: "Taylan Ulrich \"Bayırlı/Kammer\"" <taylanbayirli@gmail.com>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] gnu: Add audacity.
Date: Wed, 04 Mar 2015 10:48:13 +0100 [thread overview]
Message-ID: <87385lm6ua.fsf@gnu.org> (raw)
In-Reply-To: <87sidlemnx.fsf@taylan.uni.cx> ("Taylan Ulrich \=\?utf-8\?Q\?\=5C\=22Bay\=C4\=B1rl\=C4\=B1\=2FKammer\=5C\=22\=22's\?\= message of "Tue, 03 Mar 2015 23:33:38 +0100")
taylanbayirli@gmail.com (Taylan Ulrich "Bayırlı/Kammer") skribis:
> ludo@gnu.org (Ludovic Courtès) writes:
[...]
>> If Audacity uses Autoconf and pkg.m4, I guess you could just pass
>> PKG_CONFIG=true as a configure flag, or {LIBID3TAG,LIBMAD}_{CFLAGS,LIBS}
>> and it will just work.
>
> The latter option seems to work. (I suppose the former was meant to be
> "PKG_CONFIG=false"? That seems to break the whole library search.)
I mean ‘true’ but there were chances of breakage as you noticed.
>>> Note also it's in audacity.scm now and not audio.scm, because it depends
>>> on ffmpeg, which is in video.scm, which now imports audio.scm, so
>>> audio.scm cannot import video.scm.
>>
>> It actually can, but it’s fine (and safer) the way you propose. :-)
>
> Does Guile support circular imports? (video.scm imports audio.scm on
> the meanwhile, in case I wasn't clear about that, so I think we'll have
> to avoid importing video.scm from audio.scm.)
Modules A and B can import each other iff:
1. no top-level expressions from one module refer to bindings of the
other module;
2. neither A nor B #:selects bindings from the other.
> From 9d3ae472c1c31400753bfe89ef5d612ba6998cab Mon Sep 17 00:00:00 2001
> From: =?UTF-8?q?Taylan=20Ulrich=20Bay=C4=B1rl=C4=B1/Kammer?=
> <taylanbayirli@gmail.com>
> Date: Mon, 2 Mar 2015 01:06:35 +0100
> Subject: [PATCH 1/2] gnu: portaudio: Patch for Audacity compatibility.
>
> * gnu/packages/audio.scm (portaudio): Add a patch for Audacity compatibility.
> * gnu/packages/patches/portaudio-audacity-compat.patch: New file.
> * gnu-system.am (dist_patch_DATA): Add it.
OK.
> From 0fd1fcb065342aae81411dc62ca78fb0bc7e3afb Mon Sep 17 00:00:00 2001
> From: =?UTF-8?q?Taylan=20Ulrich=20Bay=C4=B1rl=C4=B1/Kammer?=
> <taylanbayirli@gmail.com>
> Date: Fri, 20 Feb 2015 21:52:21 +0100
> Subject: [PATCH 2/2] gnu: Add audacity.
>
> * gnu/packages/audacity.scm: New file.
> * gnu-system.am (GNU_SYSTEM_MODULES): Add it.
> * gnu/packages/patches/audacity-fix-ffmpeg-binding.patch: New file.
> * gnu-system.am (dist_patch_DATA): Add it.
OK as well.
Thank you!
Ludo’.
prev parent reply other threads:[~2015-03-04 9:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-22 0:13 [PATCH] gnu: Add audacity Taylan Ulrich Bayırlı/Kammer
2015-02-27 16:01 ` Ludovic Courtès
2015-03-03 13:10 ` Taylan Ulrich Bayırlı/Kammer
2015-03-03 20:37 ` Ludovic Courtès
2015-03-03 22:33 ` Taylan Ulrich Bayırlı/Kammer
2015-03-04 9:48 ` Ludovic Courtès [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87385lm6ua.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=guix-devel@gnu.org \
--cc=taylanbayirli@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.