all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: ludo@gnu.org (Ludovic Courtès)
To: Ricardo Wurmus <rekado@elephly.net>
Cc: Guix-devel <guix-devel@gnu.org>
Subject: Re: [PATCH] gnu: Add TuxGuitar.
Date: Tue, 21 Apr 2015 18:02:48 +0200	[thread overview]
Message-ID: <87383th3kn.fsf@gnu.org> (raw)
In-Reply-To: <874mob2zaf.fsf@mango.localdomain> (Ricardo Wurmus's message of "Mon, 20 Apr 2015 06:34:32 +0200")

Ricardo Wurmus <rekado@elephly.net> skribis:

> From 717af487b3f0924b39c8a19e25453f20859b62bf Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <rekado@elephly.net>
> Date: Sun, 19 Apr 2015 18:42:16 +0200
> Subject: [PATCH 1/2] gnu: Add SWT.
>
> * gnu/packages/java.scm (swt): New variable.

LGTM.  A common issue with Java packages is that they tend to bundle
pre-built jars, possibly coming from elsewhere.  Please make sure this
is not the case.

> From 8893511249d828d443d1b215dbcd6669da216e63 Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <rekado@elephly.net>
> Date: Sun, 19 Apr 2015 18:39:25 +0200
> Subject: [PATCH 2/2] gnu: Add TuxGuitar.
>
> * gnu/packages/music.scm (tuxguitar): New variable.

OK.

Thanks!

Ludo’.

  reply	other threads:[~2015-04-21 16:02 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-20  4:34 [PATCH] gnu: Add TuxGuitar Ricardo Wurmus
2015-04-21 16:02 ` Ludovic Courtès [this message]
2015-04-21 19:49   ` Ricardo Wurmus
2015-04-22 20:49     ` Ludovic Courtès
2015-04-23  7:06       ` Ricardo Wurmus
2015-09-20 15:39       ` Ricardo Wurmus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87383th3kn.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=guix-devel@gnu.org \
    --cc=rekado@elephly.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.