From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex Kost Subject: Re: [PATCH] xscreenshot and imagefile Date: Wed, 29 Jul 2015 20:48:33 +0300 Message-ID: <873806vor2.fsf@gmail.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:43213) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZKVT6-0007FI-Ru for guix-devel@gnu.org; Wed, 29 Jul 2015 13:48:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZKVT1-0003NA-GY for guix-devel@gnu.org; Wed, 29 Jul 2015 13:48:40 -0400 Received: from mail-lb0-x230.google.com ([2a00:1450:4010:c04::230]:33253) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZKVT1-0003Mu-8A for guix-devel@gnu.org; Wed, 29 Jul 2015 13:48:35 -0400 Received: by lbbyj8 with SMTP id yj8so11946823lbb.0 for ; Wed, 29 Jul 2015 10:48:34 -0700 (PDT) In-Reply-To: (Orchidaceae Phalaenopsis's message of "Mon, 27 Jul 2015 17:50:00 +0000") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Orchidaceae Phalaenopsis Cc: guix-devel@gnu.org Orchidaceae Phalaenopsis (2015-07-27 20:50 +0300) wrote: > Hello > > I would like to contribute packages for two programs: > > * xscreenshot which takes a screenshot and saves it as .if format > * imagefile which contains a few programs to convert .if to gif, png Hello, thanks for contributing! > From ee624abf3aada75b5fa234eec0b28fd5e2c561b0 Mon Sep 17 00:00:00 2001 > From: Alf Levan > Date: Mon, 27 Jul 2015 18:34:44 +0100 > Subject: [PATCH 1/2] gnu: Add xscreenshot. > > * gnu/packages/suckless.scm (xscreenshot): New variable. Please add a copyright line for yourself to "suckless.scm" in the first patch: ;;; Copyright =C2=A9 2015 Alf Levan BTW is it "Alf Levan" (as in the commits) or "Orchidaceae Phalaenopsis" (as in the emails)? [...] > +(define-public xscreenshot > + (package > + (name "xscreenshot") > + (version "1.0") > + (source (origin > + (method git-fetch) > + (uri (git-reference > + (url "git://git.2f30.org/xscreenshot") > + (commit "cb8ad23"))) I think it is better to use "1.0.cb8ad23" for version, so: (let ((commit "cb8ad23")) (package ...)) See 'guix-devel' package, for example. The same for 'imagefile' package. > + (sha256 > + (base32 > + "1sqhxybzi8mmb0jg78swp0vpbdiqhckd283k33lfffsd0lkgch88")))) > + (build-system gnu-build-system) > + (arguments > + '(#:tests? #f ; no tests > + #:make-flags (list "CC=3Dgcc" > + (string-append "PREFIX=3D" %output)) > + #:phases > + (modify-phases %standard-phases > + (delete 'configure)))) > + (inputs > + `(("libx11" ,libx11))) > + (native-inputs `(("pkg-config" ,pkg-config))) > + (home-page "http://git.2f30.org/xscreenshot/") > + (synopsis "Make screenshot") > + (description > + "xscreenshot is a simple screenshot utility. It writes image data t= o stdout.") Description lines for both packages are too long, please fill to 72-78 column. > + (license license:x11))) AFAICS is the same as , so it should be 'expat', not 'x11'. [...] > +(define-public imagefile > + (package > + (name "imagefile") > + (version "1.0") This thing doesn't mention any version in the source code at all, so I don't know, maybe just use "0.787ebb0" (with the used commit). What do others think? --=20 Alex