From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: Re: [PATCH 1/3] gnu: Add llfuse. Date: Mon, 31 Aug 2015 13:52:13 +0200 Message-ID: <8737yzbrpu.fsf@gnu.org> References: <87d1y48s7b.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:42125) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZWNdM-0004j5-HP for guix-devel@gnu.org; Mon, 31 Aug 2015 07:52:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZWNdI-0003hr-CF for guix-devel@gnu.org; Mon, 31 Aug 2015 07:52:20 -0400 In-Reply-To: <87d1y48s7b.fsf@gmail.com> (Alex Kost's message of "Sun, 30 Aug 2015 22:57:44 +0300") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Alex Kost Cc: guix-devel@gnu.org Alex Kost skribis: > Leo Famulari (2015-08-26 20:16 +0300) wrote: [...] >> + (description "Python-LLFUSE is a set of Python bindings for the low = level >> +FUSE API. It requires at least FUSE 2.8.0 and supports both Python 2.x= and >> +3.x.") > > IMHO mentioning a version of fuse is not needed. And IIUC this package > provides a python3 library, so I would also remove "supports both =E2=80= =A6". +1 >> + (home-page "https://bitbucket.org/nikratio/python-llfuse/") >> + (license lgpl2.0))) > > It should be 'lgpl2.0+' as the LICENSE file says "or (at your option) > any later version". Yes. Leo, could you also check a few source file headers to confirm they either have the =E2=80=9Cor later=E2=80=9D clause, or do not specify a= ny version? > Also I think it is better to put this package in "python.scm" as it just > contains some general python library. But I'm not an expert here, so > better wait for comments of other people. Agreed. > But I would name it 'python-llfuse' and would also add 'python2-llfuse' > package (bug again: I didn't make a single python package). Right. See the convention described at . Leo, could you send an updated patch? Thanks, Ludo=E2=80=99.