From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: Re: [PATCH] emacs: Add "View graph" actions to system graph commands. Date: Fri, 16 Oct 2015 10:16:06 +0200 Message-ID: <8737xbw7nd.fsf@gnu.org> References: <87a8rjkj8y.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:36727) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zn0BQ-0004uz-De for guix-devel@gnu.org; Fri, 16 Oct 2015 04:16:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zn0BN-0001QB-6I for guix-devel@gnu.org; Fri, 16 Oct 2015 04:16:12 -0400 In-Reply-To: <87a8rjkj8y.fsf@gmail.com> (Alex Kost's message of "Thu, 15 Oct 2015 22:46:21 +0300") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Alex Kost Cc: guix-devel@gnu.org Alex Kost skribis: > From 79027171c9be2cececde951caf54758c4e1bb8f5 Mon Sep 17 00:00:00 2001 > From: Alex Kost > Date: Thu, 15 Oct 2015 22:10:32 +0300 > Subject: [PATCH] emacs: Add "View graph" actions to system graph commands. > > * emacs/guix-command.el (guix-command-additional-execute-arguments, > guix-command-special-executors): Add "View graph" actions for > 'dmd-graph' and 'extension-graph' commands. > * doc/emacs.texi (Emacs Popup Interface): Document "View graph" action. Excellent! Perhaps the documentation part should go in a separate commit since it=E2= =80=99s not strictly related to the new commands? > +Several commands (@command{guix graph}, @command{guix system dmd-graph} > +and @command{guix system extension-graph}) also have a ``View graph'' > +action, which allows to view a generated graph using @command{dot} ^^^ =E2=80=9Cwhich allows you to view=E2=80=9D > +command (specified by @code{guix-dot-program} variable). By default a > +PNG file will be saved in @file{/tmp} directory and will be opened Not directly related to this patch, but I wonder if this would work with a PDF opened with DocView? That would allow people to zoom in etc. > +@item guix-dot-file-name-function > +Function used to define a name of the generated graph file. Default > +name is @file{/tmp/graph-XXXXXX.png}. Not related to this patch either, but we might consider changing the template to /tmp/guix-el-graph-XXXX.png for clarity. Otherwise LGTM. Thank you! Ludo=E2=80=99.