From: ludo@gnu.org (Ludovic Courtès)
To: Alex Kost <alezost@gmail.com>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] emacs: Add "View graph" actions to system graph commands.
Date: Fri, 16 Oct 2015 10:16:06 +0200 [thread overview]
Message-ID: <8737xbw7nd.fsf@gnu.org> (raw)
In-Reply-To: <87a8rjkj8y.fsf@gmail.com> (Alex Kost's message of "Thu, 15 Oct 2015 22:46:21 +0300")
Alex Kost <alezost@gmail.com> skribis:
> From 79027171c9be2cececde951caf54758c4e1bb8f5 Mon Sep 17 00:00:00 2001
> From: Alex Kost <alezost@gmail.com>
> Date: Thu, 15 Oct 2015 22:10:32 +0300
> Subject: [PATCH] emacs: Add "View graph" actions to system graph commands.
>
> * emacs/guix-command.el (guix-command-additional-execute-arguments,
> guix-command-special-executors): Add "View graph" actions for
> 'dmd-graph' and 'extension-graph' commands.
> * doc/emacs.texi (Emacs Popup Interface): Document "View graph" action.
Excellent!
Perhaps the documentation part should go in a separate commit since it’s
not strictly related to the new commands?
> +Several commands (@command{guix graph}, @command{guix system dmd-graph}
> +and @command{guix system extension-graph}) also have a ``View graph''
> +action, which allows to view a generated graph using @command{dot}
^^^
“which allows you to view”
> +command (specified by @code{guix-dot-program} variable). By default a
> +PNG file will be saved in @file{/tmp} directory and will be opened
Not directly related to this patch, but I wonder if this would work with
a PDF opened with DocView? That would allow people to zoom in etc.
> +@item guix-dot-file-name-function
> +Function used to define a name of the generated graph file. Default
> +name is @file{/tmp/graph-XXXXXX.png}.
Not related to this patch either, but we might consider changing the
template to /tmp/guix-el-graph-XXXX.png for clarity.
Otherwise LGTM.
Thank you!
Ludo’.
next prev parent reply other threads:[~2015-10-16 8:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-15 19:46 [PATCH] emacs: Add "View graph" actions to system graph commands Alex Kost
2015-10-16 8:16 ` Ludovic Courtès [this message]
2015-10-16 16:57 ` [PATCH] doc: emacs: Document "View graph" popup action Alex Kost
2015-10-17 13:23 ` Ludovic Courtès
2015-10-16 16:58 ` [PATCH] emacs: Improve file names of generated graphs Alex Kost
2015-10-17 13:23 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8737xbw7nd.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=alezost@gmail.com \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.