Re: [PATCH] emacs: Add "View graph" actions to system graph commands.

[ludo@gnu.org (Ludovic Courtès)]

Alex Kost <alezost@gmail.com> skribis:

> From 79027171c9be2cececde951caf54758c4e1bb8f5 Mon Sep 17 00:00:00 2001
> From: Alex Kost <alezost@gmail.com>
> Date: Thu, 15 Oct 2015 22:10:32 +0300
> Subject: [PATCH] emacs: Add "View graph" actions to system graph commands.
>
> * emacs/guix-command.el (guix-command-additional-execute-arguments,
>   guix-command-special-executors): Add "View graph" actions for
>   'dmd-graph' and 'extension-graph' commands.
> * doc/emacs.texi (Emacs Popup Interface): Document "View graph" action.

Excellent!

Perhaps the documentation part should go in a separate commit since it’s
not strictly related to the new commands?

> +Several commands (@command{guix graph}, @command{guix system dmd-graph}
> +and @command{guix system extension-graph}) also have a ``View graph''
> +action, which allows to view a generated graph using @command{dot}
                      ^^^
“which allows you to view”

> +command (specified by @code{guix-dot-program} variable).  By default a
> +PNG file will be saved in @file{/tmp} directory and will be opened

Not directly related to this patch, but I wonder if this would work with
a PDF opened with DocView?  That would allow people to zoom in etc.

> +@item guix-dot-file-name-function
> +Function used to define a name of the generated graph file.  Default
> +name is @file{/tmp/graph-XXXXXX.png}.

Not related to this patch either, but we might consider changing the
template to /tmp/guix-el-graph-XXXX.png for clarity.

Otherwise LGTM.

Thank you!

Ludo’.