From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mathieu Lirzin Subject: bug#19219: Package names with digits following dashes Date: Tue, 22 Dec 2015 22:23:26 +0100 Message-ID: <8737uu9pro.fsf@gnu.org> References: <20141129203122.GA15720@debian> <87ppbws61p.fsf@gnu.org> <874mfssrxd.fsf@gnu.org> <87si3ah1d1.fsf@gnu.org> <87h9jblks4.fsf@gnu.org> <87k2o7h3ux.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:37373) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aBUPf-000078-Kc for bug-guix@gnu.org; Tue, 22 Dec 2015 16:24:08 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aBUPa-0004cN-LW for bug-guix@gnu.org; Tue, 22 Dec 2015 16:24:07 -0500 Received: from debbugs.gnu.org ([208.118.235.43]:52602) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aBUPa-0004cJ-Hv for bug-guix@gnu.org; Tue, 22 Dec 2015 16:24:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84) (envelope-from ) id 1aBUPa-0003vA-Bm for bug-guix@gnu.org; Tue, 22 Dec 2015 16:24:02 -0500 Sender: "Debbugs-submit" Resent-Message-ID: In-Reply-To: <87k2o7h3ux.fsf@gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\= \=\?utf-8\?Q\?s\?\= message of "Mon, 21 Dec 2015 22:46:30 +0100") List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org Sender: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 19219@debbugs.gnu.org ludo@gnu.org (Ludovic Court=C3=A8s) writes: > Mathieu Lirzin skribis: > >> The test case contains the example "guile-2.0.6.65-134c9" which >> invalidates my proposal. Here is another idea which identifies the >> version part by the presence of dots. WDYT? > > Sometimes the version part does not contain dots, as in =E2=80=9Cdiffosco= pe-34=E2=80=9D. > Here=E2=80=99s the complete list of dot-less versions: Oops, I have totally overlooked that. I have blindly followed the examples in the test case. Sorry about that. > scheme@(guile-user)> ,use(gnu packages) > scheme@(guile-user)> (fold-packages (lambda (p r) > (if (string-index (package-version p) #\.) > r > (cons (package-full-name p) r))) > '()) > $38 =3D ("xterm-320" "unclutter-8" "tidy-20091223" "perl-uri-find-2014070= 9" "libx264-20150706-2245" "vapoursynth-28" "texlive-texmf-2015" "texlive-b= in-2015" "texlive-2015" "scmutils-20140302" "perl-regexp-common-2013031301"= "parallel-20151122" "diffoscope-34" "mg-20050429" "ngircd-22" "bootstrap-t= arballs-0" "static-binaries-tarball-0" "usbutils-006" "kmod-17" "less-481" = "libjpeg-9a" "libjpeg-8d" "hugs-Sep2006" "ghc-bifunctors-5" "ghc-nats-1" "b= rdf-explorer-17" "libgudev-230" "psutils-17" "gcal-4" "libspiro-20071029" "= fontforge-20120731-b" "font-gnu-freefont-ttf-20100919" "pcb-20140316" "pare= dit-24" "sfarkxtc-b5e0a2ba39" "lz4-131" "ld-wrapper-0" "glibc-bootstrap-0" = "gcc-bootstrap-0" "binutils-bootstrap-0" "bootstrap-binaries-0" "bless-1p02= " "tzdata-2015c" "freepats-20060219" "acpica-20150410") > > Would they still be suitably parsed? Nope, we are screwed! :) There are too many combinaisons. > I liked that the initial algorithm was trivial, as in Nix: > [...] > DrvName::DrvName(const string & s) : hits(0) > { > name =3D fullName =3D s; > for (unsigned int i =3D 0; i < s.size(); ++i) { > /* !!! isalpha/isdigit are affected by the locale. */ > if (s[i] =3D=3D '-' && i + 1 < s.size() && !isalpha(s[i + 1])) { > name =3D string(s, 0, i); > version =3D string(s, i + 1); > break; > } > } > } Baahh. In fact I think that having the same character for separating words and version is a design flaw. This brings non desirable limitations when choosing a package name (as shown in this bug report) and/or requires a complex parsing algorithm. We could use a reserved character instead (just like we do for multiple outputs). My proposition would be to have ':' for versions and '/' for outputs, like this: guile:1.8/doc xterm-256-color:320 emacs:24.5/out WDYT? > Another option would be to return a list of possible name version pairs, > and to change the UI to try them one after another? The downside would > be that it moves complexity to the UI. Hmm=E2=80=A6 This sounds like possible non-determinism, so it feels ugly. ;) -- Mathieu Lirzin