From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex Kost Subject: Re: wip-refactor-emacs-ui and Hydra interface Date: Tue, 29 Dec 2015 11:52:59 +0300 Message-ID: <8737ulzlec.fsf@gmail.com> References: <87vb85gqes.fsf@gmail.com> <8760zwhfyi.fsf@gnu.org> <8760zv4mhz.fsf@gmail.com> <87egefijsu.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:40888) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aDq1n-00015o-G1 for guix-devel@gnu.org; Tue, 29 Dec 2015 03:53:12 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aDq1j-0003s4-CL for guix-devel@gnu.org; Tue, 29 Dec 2015 03:53:11 -0500 List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Ludovic =?utf-8?Q?Court=C3=A8s?= Cc: guix-devel@gnu.org Ludovic Court=C3=A8s (2015-12-22 00:16 +0300) wrote: > Alex Kost skribis: > >> Ludovic Court=C3=A8s (2015-12-18 01:23 +0300) wrote: [...] >>> I haven=E2=80=99t looked at the code yet, but it=E2=80=99s your area of= expertise and >>> I=E2=80=99m confident. :-) I skim over it when you think it=E2=80=99s= ready; are there >>> parts you=E2=80=99d like to be reviewed more carefully? >> >> Well, I always feel uncomfortable with commit messages. But I think the >> main part that should be reviewed is documentation (in commit 731f5e4). > > So, regarding the documentation: > > +@node Emacs Hydra > +@section Hydra > + > +Guix also provides an interface for @code{hydra.gnu.org} (Guix build > +farm) that allows to display Hydra builds and jobsets. This interface > +is mostly the same as the ``list''/``info'' interface for displaying > +packages and generations (@pxref{Emacs Package Management}). > > I would suggest adding a bit of context, like this: > > The continuous integration server at @code{hydra.gnu.org} builds all > the distribution packages on the supported architectures and serves > them as substitutes (@pxref{Substitutes}). Continuous integration is > currently orchestrated by @uref{https://nixos.org/hydra/, Hydra}. > > This section describes an Emacs interface to query Hydra to know the > build status of specific packages, discover recent and ongoing builds, > view build logs, and so on. This interface is mostly the same as =E2= =80=A6 > > WDYT? Sure! > I would also add a cross-reference like: > > diff --git a/doc/guix.texi b/doc/guix.texi > index 06d70ba..bf523aa 100644 > --- a/doc/guix.texi > +++ b/doc/guix.texi > @@ -1568,7 +1568,9 @@ also result from derivation builds, can be availabl= e as substitutes. >=20=20 > The @code{hydra.gnu.org} server is a front-end to a build farm that > builds packages from the GNU distribution continuously for some > -architectures, and makes them available as substitutes. This is the > +architectures, and makes them available as substitutes (@pxref{Emacs > +Hydra}, for information on how to query the continuous integration > +server). This is the > default source of substitutes; it can be overridden by passing the > @option{--substitute-urls} option either to @command{guix-daemon} > (@pxref{daemon-substitute-urls,, @code{guix-daemon --substitute-urls}}) Great, I have fixed the commit locally for these documentation changes. >>> Anyway, let me know what you think and how you=E2=80=99d like to procee= d. >> >> OK, I have done some final changes and rebased the branch on master, so >> (from my point of view) it is ready for merging. Should I spam the list >> with these (37) patches? > > I don=E2=80=99t think so. :-) > > AFAICS only elisp code is touched, and the rest of the Emacs code is > supposed to be functionally equivalent, right? Yes, only elisp code for 'list'/'info' UI was touched. I'm not sure what "functionally equivalent" means. For a user, there shouldn't be any visible changes. But the internals (I mean the code itself) was changed completely. There are also some changes in user variables (I'm mentioning them in another message). > I=E2=80=99m tempted to punt on this one and let you push the whole series. > What do people think? I agree with this proposal :-) --=20 Alex