all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: ludo@gnu.org (Ludovic Courtès)
To: Leo Famulari <leo@famulari.name>
Cc: guix-devel@gnu.org
Subject: Re: [v3 1/2] gnu: w3m: Update patch to use '-p1'.
Date: Wed, 06 Jan 2016 11:33:28 +0100	[thread overview]
Message-ID: <8737ubhu9z.fsf@gnu.org> (raw)
In-Reply-To: <9d18197ecca4fe8509e9fa7588f93b9f41ad56e1.1452045889.git.leo@famulari.name> (Leo Famulari's message of "Tue, 5 Jan 2016 21:04:59 -0500")

Leo Famulari <leo@famulari.name> skribis:

> * gnu/packages/patches/w3m-fix-compile.patch: Update to work with -p1.
> * gnu/packages/w3m.scm (w3m): Drop patch flag -p0.

I would rename the patch to, say, ‘w3m-libgc.patch’, for clarity.

> --- a/gnu/packages/patches/w3m-fix-compile.patch
> +++ b/gnu/packages/patches/w3m-fix-compile.patch
> @@ -1,15 +1,27 @@
> +From 371f256f5f300b01be228a6fd95884ea475965fc Mon Sep 17 00:00:00 2001
> +From: Leo Famulari <leo@famulari.name>
> +Date: Tue, 5 Jan 2016 16:57:29 -0500
> +Subject: [PATCH 1/4] fix compile
> +
>  https://bugs.archlinux.org/task/33397

Could you remove the Git header and write something like:

  This patch fixes w3m compilation with libgc > X.Y.

(If I understand correctly what it does.)

However, I’m surprised this is needed since libgc hasn’t changed lately?

Thanks,
Ludo’.

  parent reply	other threads:[~2016-01-06 10:33 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-06  2:04 [v3 1/2] gnu: w3m: Update patch to use '-p1' Leo Famulari
2016-01-06  2:05 ` [v3 2/2] gnu: w3m: Enable SSL, disable broken protocols and ciphers Leo Famulari
2016-01-06 10:52   ` Ludovic Courtès
2016-01-07  7:37     ` Leo Famulari
2016-01-06 10:33 ` Ludovic Courtès [this message]
2016-01-07  7:30   ` [v3 1/2] gnu: w3m: Update patch to use '-p1' Leo Famulari
2016-01-10 20:36     ` Ludovic Courtès
2016-01-06 10:33 ` Ludovic Courtès
2016-01-07  7:30   ` Leo Famulari
2016-01-10 20:34     ` Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8737ubhu9z.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=guix-devel@gnu.org \
    --cc=leo@famulari.name \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.