From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
Subject: Re: [PATCH] Fix jellyfish on non-x86_64
Date: Sat, 27 Feb 2016 22:02:24 +0100
Message-ID: <8737sdeujj.fsf@mdc-berlin.de>
References: <8760xadti8.fsf@mdc-berlin.de>
	<20160227222227.4a84eb99@debian-netbook>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:57039)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Ricardo.Wurmus@mdc-berlin.de>) id 1aZm0f-0003L7-CP
	for guix-devel@gnu.org; Sat, 27 Feb 2016 16:02:42 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Ricardo.Wurmus@mdc-berlin.de>) id 1aZm0a-0007Tx-C1
	for guix-devel@gnu.org; Sat, 27 Feb 2016 16:02:41 -0500
Received: from venus.bbbm.mdc-berlin.de ([141.80.25.30]:40642)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Ricardo.Wurmus@mdc-berlin.de>) id 1aZm0a-0007Ts-2R
	for guix-devel@gnu.org; Sat, 27 Feb 2016 16:02:36 -0500
In-Reply-To: <20160227222227.4a84eb99@debian-netbook>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Efraim Flashner <efraim@flashner.co.il>
Cc: guix-devel <guix-devel@gnu.org>


Efraim Flashner <efraim@flashner.co.il> writes:

> On Sat, 27 Feb 2016 17:10:07 +0100
> Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de> wrote:
>
>> * gnu/packages/bioinformatics.scm (jellyfish)[arguments]: Append
>>   "--with-sse=no" and "--with-int128=no" to configure flags unless the
>>   system is x86_64.
>> ---
>>  gnu/packages/bioinformatics.scm | 6 +++++-
>>  1 file changed, 5 insertions(+), 1 deletion(-)
>> 
>> diff --git a/gnu/packages/bioinformatics.scm b/gnu/packages/bioinformatics.scm
>> index 7b3838d..36bcfd4 100644
>> --- a/gnu/packages/bioinformatics.scm
>> +++ b/gnu/packages/bioinformatics.scm
>> @@ -1984,7 +1984,11 @@ experiments and provide highly stable thresholds based on reproducibility.")
>>         (list (string-append "--enable-ruby-binding="
>>                              (assoc-ref %outputs "ruby"))
>>               (string-append "--enable-python-binding="
>> -                            (assoc-ref %outputs "python")))
>> +                            (assoc-ref %outputs "python"))
>> +             ,@(let ((system (or (%current-target-system) (%current-system))))
>> +                 (if (string-prefix? "x86_64" system)
>> +                     '()
>> +                    '("--with-sse=no" "--with-int128=no"))))
>                        ^^
> this looks like it's spaced off by 1

Oh, indeed.  Fixed.
Is the general idea okay, though?

~~ Ricardo