From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: Re: [PATCH] gnu: Add bash-tap. Date: Fri, 18 Mar 2016 21:49:01 +0100 Message-ID: <8737rnms02.fsf@gnu.org> References: <8760wlrst0.fsf@gnu.org> <20160318184342.GB9682@jasmine> <20160318185339.GA20746@solar> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:51254) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ah1KY-0006wE-IL for guix-devel@gnu.org; Fri, 18 Mar 2016 16:49:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ah1KT-00033W-EK for guix-devel@gnu.org; Fri, 18 Mar 2016 16:49:10 -0400 In-Reply-To: <20160318185339.GA20746@solar> (Andreas Enge's message of "Fri, 18 Mar 2016 19:53:39 +0100") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Andreas Enge Cc: guix-devel@gnu.org Andreas Enge skribis: > I had a look (without having much experience with the trivial build syste= m), > and it looks mostly clean. However, the package installs three bash scrip= ts > that start with "#!/bin/bash". This will not work on GuixSD, where only > /bin/sh exists. It should be patched by adding bash as an input and > substituting. Alternatively, you could use the gnu-build-system, delete m= ost > of the phases, set #:tests? to #f and add a custom install phase; then the > patch-shebangs phase will do its magic. Alternately, the builder could manually invoke the =E2=80=98patch-shebangs= =E2=80=99 phase, which is a regular procedure: (use-modules (guix build gnu-build-system)) ((assoc-ref %standard-phases 'patch-shebangs) %build-inputs %outputs) Ludo=E2=80=99.