From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex Kost Subject: Re: [PATCH 2/6] build-system/emacs: Use "emacs" from native-inputs if specified. Date: Sat, 21 May 2016 00:21:36 +0300 Message-ID: <8737pc1l3z.fsf@gmail.com> References: <1463422824-7161-1-git-send-email-alezost@gmail.com> <1463422824-7161-3-git-send-email-alezost@gmail.com> <8737pez2ip.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:45041) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b3t72-00027I-O8 for guix-devel@gnu.org; Fri, 20 May 2016 18:41:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b3rrV-0006na-AB for guix-devel@gnu.org; Fri, 20 May 2016 17:21:40 -0400 List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Ludovic =?utf-8?Q?Court=C3=A8s?= Cc: guix-devel@gnu.org Ludovic Court=C3=A8s (2016-05-19 14:54 +0300) wrote: > Alex Kost skribis: > >> * guix/build-system/emacs.scm (lower): Do not add "emacs" to >> build-inputs if it is already specified in the native-inputs. > > In theory, one could want to have Emacs both in =E2=80=98native-inputs=E2= =80=99 (to > build .elc files, for instance) and in =E2=80=98inputs=E2=80=99 (for inst= ance because > the program embeds a reference to the =E2=80=98emacs=E2=80=99 program.) I don't see a problem here, if "emacs" should be added to inputs, it may just go there. Nothing prohibits it. > So I=E2=80=99m rather reluctant about this approach. > > Did you find packages where Emacs wrongfully appears twice in the > inputs? It might be best to fix those packages instead. Do you mean: appears both in "inputs" and "native-inputs"? If so, then no, there are no such packages. But I don't understand how this concerns. The purpose of this patch is to allow us to use a different "emacs" to build emacs packages. I would say this is the core patch of the whole patchset. I didn't like the fact that emacs-build-system uses a full-featured (and heavy on dependencies) "emacs" package, and I would like to use "emacs-minimal" instead. But for some rare cases (currently only for auctex), "emacs-minimal" (or "emacs-no-x") is not enough, so it should be substituted somehow. That's why I made this patch. --=20 Alex