all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Alex Kost <alezost@gmail.com>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH 2/6] build-system/emacs: Use "emacs" from native-inputs if specified.
Date: Sat, 21 May 2016 00:21:36 +0300	[thread overview]
Message-ID: <8737pc1l3z.fsf@gmail.com> (raw)
In-Reply-To: 8737pez2ip.fsf@gnu.org

Ludovic Courtès (2016-05-19 14:54 +0300) wrote:

> Alex Kost <alezost@gmail.com> skribis:
>
>> * guix/build-system/emacs.scm (lower): Do not add "emacs" to
>>   build-inputs if it is already specified in the native-inputs.
>
> In theory, one could want to have Emacs both in ‘native-inputs’ (to
> build .elc files, for instance) and in ‘inputs’ (for instance because
> the program embeds a reference to the ‘emacs’ program.)

I don't see a problem here, if "emacs" should be added to inputs, it may
just go there.  Nothing prohibits it.

> So I’m rather reluctant about this approach.
>
> Did you find packages where Emacs wrongfully appears twice in the
> inputs?  It might be best to fix those packages instead.

Do you mean: appears both in "inputs" and "native-inputs"?  If so, then
no, there are no such packages.

But I don't understand how this concerns.  The purpose of this patch is
to allow us to use a different "emacs" to build emacs packages.  I
would say this is the core patch of the whole patchset.  I didn't like
the fact that emacs-build-system uses a full-featured (and heavy on
dependencies) "emacs" package, and I would like to use "emacs-minimal"
instead.  But for some rare cases (currently only for auctex),
"emacs-minimal" (or "emacs-no-x") is not enough, so it should be
substituted somehow.  That's why I made this patch.

-- 
Alex

  reply	other threads:[~2016-05-20 22:41 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-16 18:20 [PATCH 0/6] Modifications in building emacs packages Alex Kost
2016-05-16 18:20 ` [PATCH 1/6] gnu: Add emacs-minimal Alex Kost
2016-05-19 11:52   ` Ludovic Courtès
2016-05-16 18:20 ` [PATCH 2/6] build-system/emacs: Use "emacs" from native-inputs if specified Alex Kost
2016-05-19 11:54   ` Ludovic Courtès
2016-05-20 21:21     ` Alex Kost [this message]
2016-05-16 18:20 ` [PATCH 3/6] build-system/emacs: Use 'emacs-minimal' as default emacs for building Alex Kost
2016-05-19 11:55   ` Ludovic Courtès
2016-05-16 18:20 ` [PATCH 4/6] gnu: emacs-auctex: Use 'emacs' for byte-compiling Alex Kost
2016-05-19 11:56   ` Ludovic Courtès
2016-05-16 18:20 ` [PATCH 5/6] gnu: Move emacs for building from inputs to native-inputs Alex Kost
2016-05-19 11:57   ` Ludovic Courtès
2016-05-21 11:08     ` Alex Kost
2016-05-16 18:20 ` [PATCH 6/6] gnu: Use 'emacs-minimal' instead of 'emacs-no-x' Alex Kost
2016-05-19 11:58   ` Ludovic Courtès
  -- strict thread matches above, loose matches on Subject: below --
2016-05-20  7:15 [PATCH 2/6] build-system/emacs: Use "emacs" from native-inputs if specified Federico Beffa
2016-05-20 12:00 ` Ludovic Courtès
2016-05-20 21:24   ` Alex Kost
2016-05-22 20:30     ` Ludovic Courtès
2016-05-20 21:37 ` Alex Kost

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8737pc1l3z.fsf@gmail.com \
    --to=alezost@gmail.com \
    --cc=guix-devel@gnu.org \
    --cc=ludo@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.