From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex Kost Subject: Re: [PATCH 1/2] build: emacs: Handle sources that are a single elisp file. Date: Sat, 28 May 2016 22:05:24 +0300 Message-ID: <8737p20zrf.fsf@gmail.com> References: <1464358215-4416-1-git-send-email-dthompson2@worcester.edu> <87lh2ujiu3.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:57906) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b6jY8-0000hV-78 for guix-devel@gnu.org; Sat, 28 May 2016 15:05:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b6jY4-0002EE-4s for guix-devel@gnu.org; Sat, 28 May 2016 15:05:27 -0400 In-Reply-To: <87lh2ujiu3.fsf@gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\= \=\?utf-8\?Q\?s\?\= message of "Sat, 28 May 2016 17:36:04 +0200") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Ludovic =?utf-8?Q?Court=C3=A8s?= Cc: guix-devel@gnu.org Ludovic Court=C3=A8s (2016-05-28 18:36 +0300) wrote: > David Thompson skribis: > >> * guix/build/emacs-build-system.scm (gnu:unpack) >> (store-file->elisp-source-file, unpack): New procedures. >> (%standard-phases): Use the new unpack procedure. > > Good idea, LGTM! > > Could you adjust users of =E2=80=98uncompressed-file-fetch=E2=80=99 in a = subsequent > commit, and remove =E2=80=98uncompressed-file-fetch=E2=80=99? I object! I mean this should be discussed at least. I would really prefer to keep (and document) 'uncompressed-file-fetch' and not to update emacs-build-system for this case. It is possible, that once we'll need to handle non-compressed files for another build system. So it should also be adjusted in the same way. But if we keep 'uncompressed-file-fetch', it will be a general decision as it can be used for any build system. --=20 Alex