From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex Kost Subject: Re: [PATCH 1/2] build: emacs: Handle sources that are a single elisp file. Date: Mon, 30 May 2016 13:14:37 +0300 Message-ID: <8737oz26pe.fsf@gmail.com> References: <1464358215-4416-1-git-send-email-dthompson2@worcester.edu> <87lh2ujiu3.fsf@gnu.org> <8737p20zrf.fsf@gmail.com> <87y46sttxx.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:56628) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b7KDY-0003L4-BM for guix-devel@gnu.org; Mon, 30 May 2016 06:14:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b7KDS-00026k-Af for guix-devel@gnu.org; Mon, 30 May 2016 06:14:39 -0400 In-Reply-To: <87y46sttxx.fsf@gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\= \=\?utf-8\?Q\?s\?\= message of "Sun, 29 May 2016 23:50:34 +0200") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Ludovic =?utf-8?Q?Court=C3=A8s?= Cc: guix-devel@gnu.org Ludovic Court=C3=A8s (2016-05-30 00:50 +0300) wrote: > Alex Kost skribis: > >> Ludovic Court=C3=A8s (2016-05-28 18:36 +0300) wrote: >> >>> David Thompson skribis: >>> >>>> * guix/build/emacs-build-system.scm (gnu:unpack) >>>> (store-file->elisp-source-file, unpack): New procedures. >>>> (%standard-phases): Use the new unpack procedure. >>> >>> Good idea, LGTM! >>> >>> Could you adjust users of =E2=80=98uncompressed-file-fetch=E2=80=99 in = a subsequent >>> commit, and remove =E2=80=98uncompressed-file-fetch=E2=80=99? >> >> I object! > > Damn it, sorry, I thought this would be uncontroversial. > >> I mean this should be discussed at least. I would really prefer to >> keep (and document) 'uncompressed-file-fetch' and not to update >> emacs-build-system for this case. It is possible, that once we'll >> need to handle non-compressed files for another build system. So it >> should also be adjusted in the same way. But if we keep >> 'uncompressed-file-fetch', it will be a general decision as it can be >> used for any build system. > > In my view, =E2=80=98uncompressed-file-fetch=E2=80=99 and the =E2=80=98em= acs-build-system=E2=80=99 > change that Dave proposes are equally good hacks, but the latter has the > advantage that people won=E2=80=99t have to think about it: they can just= use > =E2=80=98url-fetch=E2=80=99 and =E2=80=98emacs-build-system=E2=80=99 as u= sual and things will just work. > > Of course, perhaps we should consider handling flat files closer to the > core, but so far the only use case we have, AFAIK, is .el files. Thus, > it doesn=E2=80=99t seem that bad to add a special case in =E2=80=98emacs-= build-system=E2=80=99. > Pragmatic approach I suppose. ;-) > > WDYT? , OK, I wanted to write verbosely why I prefer uncompressed-file-fetch, and why we should still use it, etc.; but I've just noticed an unpleasant downside with =E2=80=98uncompressed-file-fetch=E2=80=99: for example, if you build the re= cently added "emacs-queue" package, you'll get "queue-0.1.1.el" file, which makes it impossible to do (require 'queue). With David's solution, it will be a proper "queue.el" file. So I agree now. David's patch is definitely a better solution :-) --=20 Alex