From: ludo@gnu.org (Ludovic Courtès)
To: Dennis Mungai <dmngaie@gmail.com>
Cc: guix-devel@gnu.org,
Guix-devel
<guix-devel-bounces+ericbavier=openmailbox.org@gnu.org>
Subject: Re: [PATCH]:Resend: Add LLVM, clang and clang-runtime-3.8 to GNU Guix
Date: Sun, 12 Jun 2016 18:30:31 +0200 [thread overview]
Message-ID: <8737oimkt4.fsf@gnu.org> (raw)
In-Reply-To: <CAKKYfmFaPikjowX2m0gm3qc9CL+nPMWuB2kEB5aBfb8z+GTw7A@mail.gmail.com> (Dennis Mungai's message of "Sun, 12 Jun 2016 13:17:57 +0300")
Hi!
Dennis Mungai <dmngaie@gmail.com> skribis:
> I second Pjotr on this.
>
> There are always tools that will lag behind, and having multiple LLVM
> versions is a reasonable (and possibly unavoidable) compromise, for
> now.
>
> There may be problems with conflicts should a user install such
> pipelines with differing LLVM and Clang combinations within the same
> profile, as a worst case scenario.
OK fine. Currently we have 3.6 and 3.5, so we’d add 3.8 on top of it,
right? And the ‘llvm’, ‘clang’ etc. bindings would still point to 3.6?
Does it even make sense to have unversioned bindings?
The patch you posted earlier adds a number of configure flags, different
from those currently used in ‘llvm’, and in particular:
> + "-DLLVM_INCLUDE_TESTS=OFF" ;; clang target units cannot be built (invalid test targets inherited from llvm result in build failure)
IIUC, this has the effect of disabling tests, which is something we
avoid unless there’s a good reason. I don’t understand the comment,
what’s happening?
Could you remove as many of the configure flags as needed, and add a
comment for those that need to remain?
Also, as a bonus, could you add a conforming commit log? :-)
https://www.gnu.org/software/guix/manual/html_node/Submitting-Patches.html
Thanks in advance!
Ludo’.
next prev parent reply other threads:[~2016-06-12 16:30 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-26 19:45 [PATCH]:Resend: Add LLVM, clang and clang-runtime-3.8 to GNU Guix Dennis Mungai
2016-05-26 20:13 ` Roel Janssen
2016-05-26 20:44 ` Dennis Mungai
2016-05-27 14:09 ` Eric Bavier
2016-05-27 15:07 ` Dennis Mungai
2016-05-28 9:22 ` Roel Janssen
2016-05-28 15:30 ` Ludovic Courtès
2016-05-30 22:39 ` Dennis Mungai
2016-06-10 15:42 ` Ludovic Courtès
2016-06-10 16:38 ` Pjotr Prins
2016-06-12 10:17 ` Dennis Mungai
2016-06-12 16:30 ` Ludovic Courtès [this message]
2016-06-30 18:15 ` Dennis Mungai
2016-06-30 20:44 ` Dennis Mungai
2016-07-05 20:48 ` Roel Janssen
2016-07-05 21:20 ` Dennis Mungai
2016-07-05 21:43 ` Roel Janssen
2016-07-06 4:55 ` Ricardo Wurmus
2016-07-06 11:54 ` Efraim Flashner
2016-07-06 18:08 ` Eric Bavier
2016-07-07 5:06 ` [PATCH 1/5] gnu: llvm: Update to 3.5.2 ericbavier
2016-07-07 5:06 ` [PATCH 2/5] gnu: llvm: Add "license:" prefix ericbavier
2016-07-07 5:06 ` [PATCH 3/5] gnu: llvm: Add libffi and zlib inputs ericbavier
2016-07-07 5:06 ` [PATCH 4/5] gnu: llvm: Update to 3.7.1 ericbavier
2016-07-07 5:06 ` [PATCH 5/5] gnu: llvm: Update to 3.8.0 ericbavier
2016-07-11 8:28 ` [PATCH 1/5] gnu: llvm: Update to 3.5.2 Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8737oimkt4.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=dmngaie@gmail.com \
--cc=guix-devel-bounces+ericbavier=openmailbox.org@gnu.org \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.