From mboxrd@z Thu Jan 1 00:00:00 1970 From: iyzsong@member.fsf.org (=?utf-8?B?5a6L5paH5q2m?=) Subject: Re: [PATCH 08/10] gnu: Add python-email-validator and python2-email-validator. Date: Sun, 26 Jun 2016 10:43:56 +0800 Message-ID: <8737o04qkz.fsf@member.fsf.org> References: <20160623152004.24065-1-iyzsong@gmail.com> <20160623152004.24065-4-iyzsong@gmail.com> <20160625175837.GH22624@jasmine> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:54533) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bH03R-000868-QH for guix-devel@gnu.org; Sat, 25 Jun 2016 22:44:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bH03N-0003y5-Mh for guix-devel@gnu.org; Sat, 25 Jun 2016 22:44:12 -0400 Received: from mail.openmailbox.org ([62.4.1.34]:43616) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bH03N-0003y1-GK for guix-devel@gnu.org; Sat, 25 Jun 2016 22:44:09 -0400 In-Reply-To: <20160625175837.GH22624@jasmine> (Leo Famulari's message of "Sat, 25 Jun 2016 13:58:37 -0400") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Leo Famulari Cc: guix-devel@gnu.org Leo Famulari writes: > On Thu, Jun 23, 2016 at 11:20:02PM +0800, =E5=AE=8B=E6=96=87=E6=AD=A6 wro= te: >> * gnu/packages/python.scm (python-email-validator) >> (python2-email-validator): New variables. >> --- >> gnu/packages/python.scm | 32 ++++++++++++++++++++++++++++++++ >> 1 file changed, 32 insertions(+) >>=20 >> diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm >> index ff3cb99..68123cc 100644 >> --- a/gnu/packages/python.scm >> +++ b/gnu/packages/python.scm >> @@ -9468,3 +9468,35 @@ It supports TSIG authenticated messages and EDNS0= .") >> (define-public python2-dnspython >> (package-with-python2 python-dnspython)) >>=20=20 >> +(define-public python-email-validator >> + (package >> + (name "python-email-validator") >> + (version "1.0.1") >> + (source >> + (origin (method url-fetch) >> + (uri (pypi-uri "email_validator" version)) >> + (sha256 >> + (base32 >> + "0mn8jg5h8ifl8w6a6m0hq8kbk0mzw9vm054qfamkn89b3npz52qw"))= )) > > The indentation should be shifted to the right. OK. > >> + (build-system python-build-system) >> + (arguments >> + '(#:phases >> + (modify-phases %standard-phases >> + (add-before 'build 'use-dnspython >> + (lambda _ >> + (substitute* "setup.py" >> + (("dnspython3") "dnspython")) >> + #t))))) >> + (native-inputs >> + `(("python-dnspython" ,python-dnspython) >> + ("python-idna" ,python-idna) > > Do dnspython and idna need to be native-inputs? Are they only used to > build? They're needed at runtime, and included in the pth file. But I'm not sure whether or not inputs for python should be native-inputs, I never cross build python modules for other architertures. Should I put dnspython and idna into inputs, or propagated-inputs?