From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Nieuwenhuizen Subject: Re: [PATCH 07/11] gnu: ncurses: support mingw. Date: Tue, 09 Aug 2016 17:59:26 +0200 Message-ID: <8737mevspt.fsf@gnu.org> References: <20160809064139.27872-1-janneke@gnu.org> <20160809064139.27872-8-janneke@gnu.org> <87mvkmcr9k.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:46478) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bX9RT-0001VE-SJ for guix-devel@gnu.org; Tue, 09 Aug 2016 11:59:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bX9RQ-0004Fd-Q2 for guix-devel@gnu.org; Tue, 09 Aug 2016 11:59:47 -0400 In-Reply-To: <87mvkmcr9k.fsf@gmail.com> (Alex Kost's message of "Tue, 09 Aug 2016 10:53:27 +0300") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Alex Kost Cc: guix-devel@gnu.org Alex Kost writes: >> + (mingw-target? (lambda* (#:optional (target target)) >> + (and target >> + (string-suffix? "-mingw32" targ= et)))) > > IIUC you don't use the same 'mingw-target?' procedure you added in an > earlier patch, because it is placed in (guix utils), right? Yes, something like that: the function needs to be present at in the builder, but I'm not sure how we can make that so. I tried several things but could not find a way to avoid this duplication. mingw-target? is passed the TARGET from the post-install-phase. > I don't know if (guix build utils) would be a better place for it , How would that work? mingw-target? uses %current-build-system which is defined in (guix utils). I agree that it would be nice to remove this duplication. > but I think this 'mingw-target?' may be used by other packages quite > often, so it should be available by default to avoid the same > definitions in other packages. The definition from (guix utils) is used in libiconv-if-needed, in cross-gcc, in guile and in readline. Greetings, Jan --=20 Jan Nieuwenhuizen | GNU LilyPond http://lilypond.org Freelance IT http://JoyofSource.com | Avatar=C2=AE http://AvatarAcademy.nl= =20=20