From mboxrd@z Thu Jan  1 00:00:00 1970
From: Mark H Weaver <mhw@netris.org>
Subject: Re: [PATCH 15/24] gnu: gstreamer: Symlink gstconfig.h into include
	directory.
Date: Wed, 17 Aug 2016 05:28:10 -0400
Message-ID: <8737m3ycb9.fsf@netris.org>
References: <20160816183938.22794-1-david@craven.ch>
	<20160816183938.22794-15-david@craven.ch>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:52560)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mhw@netris.org>) id 1bZxAE-0000RP-AH
	for guix-devel@gnu.org; Wed, 17 Aug 2016 05:29:35 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mhw@netris.org>) id 1bZxA9-0000gV-Vp
	for guix-devel@gnu.org; Wed, 17 Aug 2016 05:29:33 -0400
Received: from world.peace.net ([50.252.239.5]:54136)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mhw@netris.org>) id 1bZxA9-0000gL-RR
	for guix-devel@gnu.org; Wed, 17 Aug 2016 05:29:29 -0400
In-Reply-To: <20160816183938.22794-15-david@craven.ch> (David Craven's message
	of "Tue, 16 Aug 2016 20:39:29 +0200")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: David Craven <david@craven.ch>
Cc: guix-devel@gnu.org

David Craven <david@craven.ch> writes:

> * gnu/packages/gstreamer.scm (gstreamer)[arguments]: Add symlink-gstconfig.h
>   phase.

What is the reason for this change?  Would it be appropriate to submit a
bug report upstream to add this to their "make install"?

      Mark
      

> ---
>  gnu/packages/gstreamer.scm | 11 ++++++++++-
>  1 file changed, 10 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/gstreamer.scm b/gnu/packages/gstreamer.scm
> index bd99880..54919cd 100644
> --- a/gnu/packages/gstreamer.scm
> +++ b/gnu/packages/gstreamer.scm
> @@ -113,7 +113,16 @@ arrays of data.")
>       `(#:configure-flags
>         (list (string-append "--with-html-dir="
>                              (assoc-ref %outputs "doc")
> -                            "/share/gtk-doc/html"))))
> +                            "/share/gtk-doc/html"))
> +       #:phases
> +        (modify-phases %standard-phases
> +          (add-after 'install 'symlink-gstconfig.h
> +            (lambda* (#:key outputs #:allow-other-keys)
> +              (symlink
> +                (string-append (assoc-ref outputs "out")
> +                 "/lib/gstreamer-1.0/include/gst/gstconfig.h")
> +                (string-append (assoc-ref outputs "out")
> +                 "/include/gstreamer-1.0/gst/gstconfig.h")))))))
>      (propagated-inputs `(("glib" ,glib))) ; required by gstreamer-1.0.pc.
>      (native-inputs
>       `(("bison" ,bison)