From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex Kost Subject: Re: [PATCH v2] gnu: Add python-odfpy. Date: Fri, 02 Sep 2016 11:39:53 +0300 Message-ID: <8737li4rvq.fsf@gmail.com> References: <87h99zr5kb.fsf@ike.i-did-not-set--mail-host-address--so-tickle-me> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:55348) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bfk13-0004xw-F7 for guix-devel@gnu.org; Fri, 02 Sep 2016 04:40:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bfk0x-0002lR-O3 for guix-devel@gnu.org; Fri, 02 Sep 2016 04:40:00 -0400 Received: from mail-lf0-x243.google.com ([2a00:1450:4010:c07::243]:36621) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bfk0x-0002lK-GJ for guix-devel@gnu.org; Fri, 02 Sep 2016 04:39:55 -0400 Received: by mail-lf0-x243.google.com with SMTP id k10so763419lfe.3 for ; Fri, 02 Sep 2016 01:39:55 -0700 (PDT) In-Reply-To: <87h99zr5kb.fsf@ike.i-did-not-set--mail-host-address--so-tickle-me> (Marius Bakke's message of "Thu, 01 Sep 2016 16:41:08 +0100") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Marius Bakke Cc: guix-devel@gnu.org Marius Bakke (2016-09-01 18:41 +0300) wrote: > From f1bccf9bf26088107b6fec31eece30676d5a362f Mon Sep 17 00:00:00 2001 > From: Marius Bakke > Date: Wed, 17 Aug 2016 17:45:24 +0100 > Subject: [PATCH] gnu: Add python-odfpy. > > * gnu/packages/python.scm (python-odfpy, python2-odfpy): New variables. [...] > + (arguments > + `(#:phases > + (modify-phases %standard-phases > + (replace 'check > + ;; The test runner invokes python2 and python3 for test*.py. > + ;; To avoid having both in inputs, we replicate it here. > + (lambda _ > + (for-each (lambda (test-file) 'every' procedure should be used here instead: 'for-each' is for side effects only, its returned value is unspecified; and with 'every', the check phase will fail if any of the tests fails. And since 'every' is from (srfi srfi-1) module, we need to use it in 'arguments', like this: #:modules ((srfi srfi-1) (guix build python-build-system) (guix build utils)) The rest looks good to me, so if there will be no other comments, I will commit it in several days, thanks! > + (zero? (system* "python" test-file))) > + (find-files "tests" "^test.*\\.py$"))))))) > + (build-system python-build-system) > + (home-page "https://github.com/eea/odfpy") > + (synopsis "Python API and tools to manipulate OpenDocument files") > + (description "Collection of libraries and utility programs written in > +Python to manipulate OpenDocument 1.2 files.") > + (license > + ;; The software is mainly dual GPL2+ and ASL2.0, but includes a > + ;; number of files with different licenses. > + (list license:gpl2+ license:asl2.0 license:lgpl2.1+ license:cc-by-sa3.0)))) > + > +(define-public python2-odfpy > + (package-with-python2 python-odfpy)) -- Alex