From: "Clément Lassieur" <clement@lassieur.org>
To: Efraim Flashner <efraim@flashner.co.il>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] gnu: Add git-review.
Date: Fri, 09 Sep 2016 22:27:55 +0200 [thread overview]
Message-ID: <8737l8lsxg.fsf@lassieur.org> (raw)
In-Reply-To: <87eg4tf3c7.fsf@lassieur.org>
Clément Lassieur <clement@lassieur.org> writes:
> With the patch already pushed, I get this error:
>
> --8<---------------cut here---------------start------------->8---
> Using global/system git-review config files (/etc/git-review/git-review.conf) is deprecated
> Downloading refs/changes/73/36373/1 from gerrit
> Traceback (most recent call last):
> File "/gnu/store/ss27c082a95dzra46lsv9fwg0sw6x7zg-python-git-review-1.25.0/bin/.git-review-real", line 10, in <module>
> sys.exit(main())
> File "/gnu/store/ss27c082a95dzra46lsv9fwg0sw6x7zg-python-git-review-1.25.0/lib/python3.4/site-packages/git_review/cmd.py", line 1522, in main
> _main()
> File "/gnu/store/ss27c082a95dzra46lsv9fwg0sw6x7zg-python-git-review-1.25.0/lib/python3.4/site-packages/git_review/cmd.py", line 1437, in _main
> checkout_review(local_branch, remote, remote_branch)
> File "/gnu/store/ss27c082a95dzra46lsv9fwg0sw6x7zg-python-git-review-1.25.0/lib/python3.4/site-packages/git_review/cmd.py", line 1123, in checkout_review
> branch_name, "FETCH_HEAD")
> File "/gnu/store/ss27c082a95dzra46lsv9fwg0sw6x7zg-python-git-review-1.25.0/lib/python3.4/site-packages/git_review/cmd.py", line 160, in run_command_exc
> (rc, output) = run_command_status(*argv, **env)
> File "/gnu/store/ss27c082a95dzra46lsv9fwg0sw6x7zg-python-git-review-1.25.0/lib/python3.4/site-packages/git_review/cmd.py", line 144, in run_command_status
> env=newenv)
> File "/gnu/store/m4gc2wx4q9if1vrhgclpspdil7rqsn21-python-3.4.3/lib/python3.4/subprocess.py", line 859, in __init__
> restore_signals, start_new_session)
> File "/gnu/store/m4gc2wx4q9if1vrhgclpspdil7rqsn21-python-3.4.3/lib/python3.4/subprocess.py", line 1395, in _execute_child
> restore_signals, start_new_session, preexec_fn)
> UnicodeEncodeError: 'ascii' codec can't encode character '\xe9' in position 9: ordinal not in range(128)
> --8<---------------cut here---------------end--------------->8---
>
> I'm sorry I didn't test it well enough. Maybe we should revert it, since
> it's probably unusable.
I had this error on a Debian/Guix laptop (without guix environment), but
I don't have it with my GuixSD laptop.
next prev parent reply other threads:[~2016-09-09 20:28 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-08 7:06 [PATCH] gnu: Add git-review Clément Lassieur
2016-09-08 7:37 ` Vincent Legoll
2016-09-08 10:16 ` Efraim Flashner
2016-09-08 12:28 ` [PATCH] gnu: Add python-git-review Clément Lassieur
2016-09-08 17:45 ` Efraim Flashner
2016-09-08 12:28 ` [PATCH] gnu: Add git-review Ben Woodcroft
2016-09-08 17:58 ` Efraim Flashner
2016-09-09 16:24 ` Clément Lassieur
2016-09-09 20:27 ` Clément Lassieur [this message]
2016-09-08 18:32 ` Efraim Flashner
2016-09-09 8:23 ` Clément Lassieur
2016-09-09 15:00 ` Efraim Flashner
2016-09-09 16:09 ` Clément Lassieur
2016-09-10 19:05 ` Efraim Flashner
2016-09-10 21:13 ` [PATCH] gnu: python-git-review: Wrap it so 'git', 'ssh' and 'scp' are found Clément Lassieur
2016-09-11 7:05 ` Efraim Flashner
2016-09-10 21:25 ` [PATCH] gnu: Add git-review Clément Lassieur
2016-09-09 18:49 ` Alex Kost
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8737l8lsxg.fsf@lassieur.org \
--to=clement@lassieur.org \
--cc=efraim@flashner.co.il \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.