From: Roel Janssen <roel@gnu.org>
To: Thomas Danckaert <post@thomasdanckaert.be>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] gnu: Add qtwebkit.
Date: Fri, 28 Oct 2016 16:44:00 +0200 [thread overview]
Message-ID: <8737jgh6tr.fsf@gnu.org> (raw)
In-Reply-To: <20161028.112601.737405433041352600.post@thomasdanckaert.be>
Thomas Danckaert writes:
> Hi,
>
> this patch adds QtWebKit 5.7 as a separate package (hopefully this will reduce security concerns: only packages which really need QtWebKit will include it).
>
> QtWebKit is not officially supported anymore as of Qt 5.6, so this is a “community release” (not exactly sure what that entails, or if this includes any updates at all since the Qt 5.5 version). I suppose many projects are switching to Qt WebEngine, and there are some efforts to create an updated version of QtWebKit (https://github.com/annulen/webkit), but in the mean time, this package might help build packages which still rely on the old QtWebKit.
>
> By default, the qmake build system for qtwebkit insists on installing into the same prefix as qtbase, and it seems no command line parameters will change that. The solution I came up with, was to substitute all the necessary paths in the generated Makefiles. This makes the patch a bit lengthy.
>
> I've also attached a minimal example.
>
> Thomas
> QT += widgets
> QT += webkit
> QT += webkitwidgets
> SOURCES = example.cpp
>
> #include <QWebView>
> #include <QApplication>
>
> int main(int argc, char** argv) {
> QApplication app(argc, argv);
> QWebView view;
> view.show();
> view.setUrl(QUrl("https://www.gnu.org/software/guix"));
> return app.exec();
> }
Thanks a lot for this patch. I can confirm it builds fine, yet I have
to test it on some Qt packages that need QtWebkit (Texmaker).
Kind regards,
Roel Janssen
next prev parent reply other threads:[~2016-10-28 14:42 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-28 9:26 [PATCH] gnu: Add qtwebkit Thomas Danckaert
2016-10-28 14:44 ` Roel Janssen [this message]
2016-11-02 12:35 ` Roel Janssen
2016-11-02 13:00 ` Thomas Danckaert
2016-11-02 13:32 ` Roel Janssen
2016-10-30 0:22 ` Leo Famulari
2016-11-02 13:05 ` Thomas Danckaert
2016-11-05 18:45 ` Leo Famulari
2016-11-05 20:24 ` Thomas Danckaert
2016-11-07 9:17 ` Ludovic Courtès
2016-11-07 9:47 ` Roel Janssen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8737jgh6tr.fsf@gnu.org \
--to=roel@gnu.org \
--cc=guix-devel@gnu.org \
--cc=post@thomasdanckaert.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.