Re: [PATCH 7/7] gnu: Add kross.

[Marius Bakke <mbakke@fastmail.com>]

[-- Attachment #1: Type: text/plain, Size: 2708 bytes --]

Hartmut Goebel <h.goebel@crazy-compilers.com> writes:

> * gnu/packages/kde-frameworks.scm (kross): New variable.
> ---
>  gnu/packages/kde-frameworks.scm | 43 +++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 43 insertions(+)
>
> diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
> index c86d82c..88824e2 100644
> --- a/gnu/packages/kde-frameworks.scm
> +++ b/gnu/packages/kde-frameworks.scm
> @@ -3101,3 +3101,46 @@ This framework is a porting aid.  It is not recommended for new projects, and
>  existing projects that use it are advised to port away from it, and use plain
>  KParts instead.")
>      (license license:expat)))
> +
> +(define-public kross
> +  (package
> +    (name "kross")
> +    (version "5.27.0")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append
> +             "mirror://kde/stable/frameworks/"
> +             (version-major+minor version) "/portingAids/"
> +             name "-" version ".tar.xz"))
> +       (sha256
> +        (base32 "13karf890afk3dplxgsjx48vjz1ka12pgsi8qw369xbff5nqy2vj"))))
> +    (build-system cmake-build-system)
> +    (native-inputs
> +     `(("extra-cmake-modules" ,extra-cmake-modules)
> +       ("kdoctools" ,kdoctools)))
> +    (inputs
> +     `(("kcompletion" ,kcompletion)
> +       ("kcoreaddons" ,kcoreaddons)
> +       ("ki18n" ,ki18n)
> +       ("kiconthemes" ,kiconthemes)
> +       ("kparts" ,kparts)
> +       ("kwidgetsaddons" ,kwidgetsaddons)
> +       ("kxmlgui" ,kxmlgui)
> +       ("qtbase" ,qtbase)
> +       ("qtscript" ,qtscript)
> +       ("qttools" ,qttools)))
> +    (home-page "https://community.kde.org/Frameworks")
> +    (synopsis "KDE Frameworks 5 solution for application scripting")
> +    (description "Kross is a scripting bridge for the KDE Development Platform
> +used to embed scripting functionality into an application.  It supports
> +QtScript as a scripting interpreter backend.
> +
> +Kross provides an abstract API to provide scripting functionality in a
> +interpreter-independent way.  The application that uses Kross should not need
> +to know anything about the scripting language being used.  The core of Kross
> +provides the framework to deal transparently with interpreter-backends and
> +offers abstract functionality to deal with scripts.")
> +    ;; a variety of licenses
> +    (license (list license:lgpl2.0 license:lgpl2.0+ license:lgpl2.1+
> +                   license:gpl3))))

Are you sure it's GPL3, and not GPL3+? If the file headers says GPL3
only it's fine, otherwise I think we default to GPL+.

Otherwise LGTM, assuming you've checked whether qttools is referenced :)

Great to see good KDE support in Guix!

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 454 bytes --]