From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marius Bakke Subject: Re: [PATCH] gnu: Add vis, libtermkey and lua-lpeg. Date: Thu, 08 Dec 2016 15:17:59 +0100 Message-ID: <8737hyzeqw.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me> References: <3a2f94626f0729772aaf3fc1fcb16cf1@openmailbox.org> <878trrz8e2.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:56710) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cEzWS-00045h-Cr for guix-devel@gnu.org; Thu, 08 Dec 2016 09:18:12 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cEzWM-0006IT-Gx for guix-devel@gnu.org; Thu, 08 Dec 2016 09:18:08 -0500 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:52554) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cEzWM-0006II-9i for guix-devel@gnu.org; Thu, 08 Dec 2016 09:18:02 -0500 In-Reply-To: List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: =?utf-8?Q?Jos=C3=A9?= Miguel =?utf-8?Q?S=C3=A1nchez_Garc=C3=ADa?= Cc: guix-devel@gnu.org --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Jos=C3=A9 Miguel S=C3=A1nchez Garc=C3=ADa writes: > On 2016-12-07 23:23, Marius Bakke wrote: >> Jos=C3=A9 Miguel S=C3=A1nchez Garc=C3=ADa writes: >>=20 >>> Let's see if these patches get accepted now! I think I've taken into >>> account >>> every single detail. >>>=20 >>> These patches add three packages: vis, lua and libtermkey. vis depends >>> on lua >>> and libtermkey, so add them before adding vis. >>>=20 >>> vis is being added in a new file, gnu/text-editors.scm , as requested >>> here >>> >>=20 >> Thanks for these patches! >>=20 >> I've committed the first two packages with some minor edits: >>=20 >> * Indentation ran through emacs (e.g. M-x indent-region). We follow >> emacs indentation rules religiously. :-) >> * Updated commit messages to match the GNU changelog style. >> * libtermkey and lua-lpeg actually had tests. 'gnu-build-system' runs >> "make check" by default, whereas they expected "make test". This can >> be overridden with the #:test-target argument. >> * Avoided hard coding the lua version in lpeg install path. >>=20 >> 'vis' was a little more tricky. On startup it could not find the=20 >> "visrc" >> file, which you probably had in ~/.config or similar. I solved that by >> adding a "native-search-path" for VIS_PATH so Guix sets up this=20 >> variable >> when installed (this seems to be an undocumented feature of Guix :-)). >>=20 >> In a perfect world, the same trick could be used for LUA_PATH and >> LUA_CPATH to discover the optional "lpeg" module, but they don't seem=20 >> to >> behave like normal PATH specifications and requires a pattern match, >> which in turn appears to get ignored by guix'=20 >> search-path-specification. >>=20 >> Instead I wrapped the binary with the lpeg paths. This also seems to >> have fixed the problem finding themes. Can you try the attached patch >> and see if that works for you, especially if you have a custom config? > I'm in a VM, so my home directory is pretty much empty, but you're=20 > right: weeks > back when I was trying to get it working on my machine I created an=20 > empty > config file, so I forgot about it when I submitted the patches. > > I tested it, and it works fine. I'll take a look at the modifications=20 > you did > to learn more about what to do for future patches. > > Finally, thanks for finally accepting these packages. I worked really=20 > hard to > prepare them (I didn't know any Scheme before starting!), but the=20 > community has > proven to be very helpful :D. Thanks for checking (it seems you forgot to CC the list) :-) I tested it with a custom config just now, but it seems to load the one from VIS_PATH before checking ~/.config. I'm not sure how to fix that without breaking the lexer integration, so I've committed it as-is. Would be nice to have a fix for that though ;-) Thanks again for contributing! --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAlhJa5cACgkQoqBt8qM6 VPpMdAgApgcdk5Q/0HKS/RIC1kcFH3vuQe/uOb57LigDB510UiQ7SaBkRW48599A TNE726TNLmrK8FlPnT0h1d6g+TmKwp+lpTU/u+Km9f0+8em7+SInnSiEoWersyfI uZhMCL49Yqbc6M+vUNK1HX8hIfFXkTx8LcSiTC5sk6oL0+j3ibFYna/xEC4BocBg NKWZN/qrbJQr0wgbJYeLwiW7fQ6Ly0u9Zlc2XxElUghtwGau1dJqSQiCTiTkDT6/ 1QqLW66r0Vq5BKZ79TqyX937PasjlHnK3aRWovNA5NECRw/VEeMQvmsD8m0mR6Se jWOpSP0Um8Vx7BZYWFUJe4ZBlgHDEg== =T5Nt -----END PGP SIGNATURE----- --=-=-=--