From mboxrd@z Thu Jan  1 00:00:00 1970
From: ng0 <contact.ng0@cryptolab.net>
Subject: Re: [PATCH 1/2] gnu: Add mbedtls.
Date: Thu, 26 Jan 2017 14:48:28 +0000
Message-ID: <8737g527yb.fsf@wasp.i-did-not-set--mail-host-address--so-tickle-me>
References: <20170125122517.2266-1-contact.ng0@cryptolab.net>
	<20170126031105.GA17064@jasmine>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:52706)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <contact.ng0@cryptolab.net>) id 1cWlKe-00070q-MU
	for guix-devel@gnu.org; Thu, 26 Jan 2017 09:47:26 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <contact.ng0@cryptolab.net>) id 1cWlKa-0006pn-PN
	for guix-devel@gnu.org; Thu, 26 Jan 2017 09:47:24 -0500
Received: from fragranza.investici.org ([178.175.144.26]:30564)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <contact.ng0@cryptolab.net>)
	id 1cWlKa-0006oz-Du
	for guix-devel@gnu.org; Thu, 26 Jan 2017 09:47:20 -0500
In-Reply-To: <20170126031105.GA17064@jasmine>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Leo Famulari <leo@famulari.name>
Cc: guix-devel@gnu.org

Leo Famulari <leo@famulari.name> writes:

> On Wed, Jan 25, 2017 at 12:25:17PM +0000, contact.ng0@cryptolab.net wro=
te:
>> * gnu/packages/tls.scm (mbedtls): New variable.
>
>> +       ;; FIXME: Tarball on tls.mbed.org can no be fetched by our dow=
nloader.
>
> Please add a comment explaining what goes wrong.
>
>> +    (native-inputs
>> +     `(("perl" ,perl) ; Tests
>> +       ("doxygen" ,doxygen)
>> +       ("graphviz" ,graphviz)))
>> +    (inputs
>> +     `(("zlib" ,zlib)
>> +       ("openssl" ,openssl)))
>
> The only dependency it needs to build is Perl.
>
> The rest can be missing and mbedtls will still pass its test suite.
>
> Doxygen seems unused; no documentation is installed when its available.
>
> If they are available, zlib and openssl are not referred to by the outp=
ut
> (checked with `guix gc --references`).

Good catch, seems like some things have indeed changed since I
wrote the Gentoo ebuild. Check yourself I guess...
Thanks!

These are small changes, I see to send them in today. Thanks for
the review.
--=20
=E2=99=A5=E2=92=B6  ng0 -- https://www.inventati.org/patternsinthechaos/