From: ng0 <contact.ng0@cryptolab.net>
To: Leo Famulari <leo@famulari.name>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH 1/2] gnu: Add mbedtls.
Date: Thu, 26 Jan 2017 14:48:28 +0000 [thread overview]
Message-ID: <8737g527yb.fsf@wasp.i-did-not-set--mail-host-address--so-tickle-me> (raw)
In-Reply-To: <20170126031105.GA17064@jasmine>
Leo Famulari <leo@famulari.name> writes:
> On Wed, Jan 25, 2017 at 12:25:17PM +0000, contact.ng0@cryptolab.net wrote:
>> * gnu/packages/tls.scm (mbedtls): New variable.
>
>> + ;; FIXME: Tarball on tls.mbed.org can no be fetched by our downloader.
>
> Please add a comment explaining what goes wrong.
>
>> + (native-inputs
>> + `(("perl" ,perl) ; Tests
>> + ("doxygen" ,doxygen)
>> + ("graphviz" ,graphviz)))
>> + (inputs
>> + `(("zlib" ,zlib)
>> + ("openssl" ,openssl)))
>
> The only dependency it needs to build is Perl.
>
> The rest can be missing and mbedtls will still pass its test suite.
>
> Doxygen seems unused; no documentation is installed when its available.
>
> If they are available, zlib and openssl are not referred to by the output
> (checked with `guix gc --references`).
Good catch, seems like some things have indeed changed since I
wrote the Gentoo ebuild. Check yourself I guess...
Thanks!
These are small changes, I see to send them in today. Thanks for
the review.
--
♥Ⓐ ng0 -- https://www.inventati.org/patternsinthechaos/
next prev parent reply other threads:[~2017-01-26 14:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-25 12:25 [PATCH 1/2] gnu: Add mbedtls contact.ng0
2017-01-25 12:29 ` ng0
2017-01-26 3:11 ` Leo Famulari
2017-01-26 14:48 ` ng0 [this message]
2017-01-26 15:40 ` mbedtls, v2 contact.ng0
2017-01-26 15:40 ` [PATCH 1/2] gnu: Add mbedtls contact.ng0
2017-01-27 16:11 ` Add: mbedtls (v3), and hiawatha contact.ng0
2017-01-27 16:11 ` [PATCH 1/2] gnu: Add mbedtls-apache contact.ng0
2017-01-27 16:11 ` [PATCH 2/2] gnu: Add hiawatha contact.ng0
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8737g527yb.fsf@wasp.i-did-not-set--mail-host-address--so-tickle-me \
--to=contact.ng0@cryptolab.net \
--cc=guix-devel@gnu.org \
--cc=leo@famulari.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.