all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: ludo@gnu.org (Ludovic Courtès)
To: Tobias Geerinckx-Rice <me@tobias.gr>
Cc: 26314@debbugs.gnu.org
Subject: bug#26314: [PATCH] substitute: Send ‘User-Agent’ header.
Date: Fri, 31 Mar 2017 10:12:35 +0200	[thread overview]
Message-ID: <8737dt7tl8.fsf@gnu.org> (raw)
In-Reply-To: <20170330184439.8896-1-me@tobias.gr> (Tobias Geerinckx-Rice's message of "Thu, 30 Mar 2017 20:44:39 +0200")

Heya!

Tobias Geerinckx-Rice <me@tobias.gr> skribis:

> * guix/scripts/substitute.scm (narinfo-request): Pass ‘User-Agent’ #:headers
> to ‘build-request’.
> ---
>
> Guix,
>
> This makes the User-Agent sent to substitute servers consistent.
>
> Currently, ‘http-fetch’ (used to download .nars) sets it to ‘GNU Guile’,
> while http-multiple-get (used to download .narinfos) leaves it empty.

Sounds good to me.

Did the lack of ‘User-Agent’ cause you any problems?

> (This brings the number of scattered '"GNU Guile"' user-agent settings
>  in Guix to 5, but moving it to %guix-default-http-user-agent does not
>  strike me as a meaningful improvement.)

Agreed.  :-)

Go for it!

Ludo’.

  reply	other threads:[~2017-03-31  8:13 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-30 18:44 bug#26314: [PATCH] substitute: Send ‘User-Agent’ header Tobias Geerinckx-Rice
2017-03-31  8:12 ` Ludovic Courtès [this message]
2017-03-31 13:42   ` Tobias Geerinckx-Rice

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8737dt7tl8.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=26314@debbugs.gnu.org \
    --cc=me@tobias.gr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.