From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marius Bakke Subject: bug#26441: [PATCH] gnu: findutils: Fix make check issues on multi-core machines. Date: Thu, 13 Apr 2017 21:38:46 +0200 Message-ID: <8737dc9jy1.fsf@fastmail.com> References: <871sszuznt.fsf@gnu.org> <20170413163408.17571-1-m.othacehe@gmail.com> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:37950) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cykaA-0008En-CC for bug-guix@gnu.org; Thu, 13 Apr 2017 15:39:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cyka6-0002rH-V3 for bug-guix@gnu.org; Thu, 13 Apr 2017 15:39:06 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:47864) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cyka6-0002qX-DJ for bug-guix@gnu.org; Thu, 13 Apr 2017 15:39:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1cyka6-0005lb-1g for bug-guix@gnu.org; Thu, 13 Apr 2017 15:39:02 -0400 Sender: "Debbugs-submit" Resent-Message-ID: In-Reply-To: <20170413163408.17571-1-m.othacehe@gmail.com> List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org Sender: "bug-Guix" To: Mathieu Othacehe , 26441@debbugs.gnu.org --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hi, thanks for working on these! [...] =20=20 > (define-public findutils > (package > - (name "findutils") > - (version "4.6.0") > - (source (origin > - (method url-fetch) > - (uri (string-append "mirror://gnu/findutils/findutils-" > - version ".tar.gz")) > - (sha256 > - (base32 > - "178nn4dl7wbcw499czikirnkniwnx36argdnqgz4ik9i6zvwkm6y")) > - (patches (search-patches "findutils-localstatedir.patch" > - "findutils-test-xargs.patch")))) > - (build-system gnu-build-system) > - (arguments > - `(#:configure-flags (list > - ;; Tell 'updatedb' to write to /var. > - "--localstatedir=3D/var" > - > - ;; Work around cross-compilation failure. See > - ;; . > - ,@(if (%current-target-system) > - '("gl_cv_func_wcwidth_works=3Dyes") > - '())))) > - (synopsis "Operating on files matching given criteria") > - (description > - "Findutils supplies the basic file directory searching utilities of = the > + (name "findutils") > + (version "4.6.0") > + (source (origin > + (method url-fetch) > + (uri (string-append "mirror://gnu/findutils/findutils-" > + version ".tar.gz")) > + (sha256 > + (base32 > + "178nn4dl7wbcw499czikirnkniwnx36argdnqgz4ik9i6zvwkm6y")) > + (patches (search-patches > + "findutils-localstatedir.patch" > + "findutils-test-xargs.patch" > + ;; test-lock has performance issues on multi-core > + ;; machines, it hangs or takes a long time to co= mplete. > + ;; This is a commit from gnulib to fix this issu= e. > + "findutils-gnulib-multi-core.patch")))) Please don't mix large indentation changes with functional changes. It is really difficult to tell what this commit does. Can you split the indentation change out in a separate commit? --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAljv08YACgkQoqBt8qM6 VPrICgf/VilyyNjEuaKUjp88q7JOBeMocu9Lby3M9oRiLwOZzSkCsUQUV5BslX0a YI7zmvamW8LJAD0W7wZZYc35+VaeJhbBUsEHevUMcdazfZXc6Uxwh4nzvcNs3Hdu hc1vNquIJZd74PbdfqZQlyF+0O0SgnzFYtEC9E4N1F67CFkg5QeigLKZ0ow2rpeu A+o2en1yuKJTbU+vNSZvR6ZB2n1uvf5AdrGng5Zq5pdeS3FkNEb+hXzDH93ke/W4 A1UdZPyi3jyiB8lchsirwi8C2x4ekOuCDwcz879yzlO51udNuWeHj42SvhIyY44M FiDZHAjRnH4BjvFgk6tGHyXbv/rnbg== =EU6l -----END PGP SIGNATURE----- --=-=-=--