Re: 01/02: gnu: qemu: Update to 2.9.0 [security fixes].

Re: 01/02: gnu: qemu: Update to 2.9.0 [security fixes].

[Mark H Weaver]

leo@famulari.name (Leo Famulari) writes:

> lfam pushed a commit to branch master
> in repository guix.
>
> commit dfa663c963a7c0745f18cbfab4b45eb335742602
> Author: Leo Famulari <leo@famulari.name>
> Date:   Fri Apr 7 09:03:28 2017 -0400
>
>     gnu: qemu: Update to 2.9.0 [security fixes].
>     
>     Fixes CVE-2017-{5857,5973,5987,6058,6505,7377,7471,7718}.

Thanks for this!  Obviously it's an important security update, but:

On my x86_64 system running GuixSD, 'grub' now fails to build from
source.  Three times in a row, the 'grub_cmd_set_date' has failed.
Here's the relevant excerpt from test-suite.log (lightly formatted):

  FAIL: grub_cmd_set_date
  =======================
  
  qemu-system-i386: Trying to execute code outside RAM or ROM at 0xefffff53
  This usually means one of the following happened:
  
  (1) You told QEMU to execute a kernel for the wrong machine type, and
  it crashed on startup (eg trying to run a raspberry pi kernel on a
  versatilepb QEMU machine)
  
  (2) You didn't give QEMU a kernel or BIOS filename at all, and QEMU
  executed a ROM full of no-op instructions until it fell off the end
  
  (3) Your guest kernel has a bug and crashed by jumping off into nowhere
  
  This is almost always one of the first two, so check your command line
  and that you are using the right type of kernel for this machine.
  If you think option (3) is likely then you can try debugging your
  guest with the -d debug options; in particular -d guest_errors will
  cause the log to include a dump of the guest register state at this
  point.
  
  Execution cannot continue; stopping here.
  
  Test failed: 2017-04-21 00:08:44 Friday

The build appears to have succeeded on Hydra:

  https://hydra.gnu.org/eval/109616?filter=grub

Unfortunately the substitute is not yet available, so for the moment I'm
stuck.  I'll look into disabling this test for now.

Has anyone else seen this?

      Mark

Re: 01/02: gnu: qemu: Update to 2.9.0 [security fixes].

[Leo Famulari]

[-- Attachment #1: Type: text/plain, Size: 761 bytes --]

On Thu, Apr 20, 2017 at 09:06:51PM -0400, Mark H Weaver wrote:
> leo@famulari.name (Leo Famulari) writes:
> >     gnu: qemu: Update to 2.9.0 [security fixes].
> 
> Thanks for this!  Obviously it's an important security update, but:
> 
> On my x86_64 system running GuixSD, 'grub' now fails to build from
> source.  Three times in a row, the 'grub_cmd_set_date' has failed.
> Here's the relevant excerpt from test-suite.log (lightly formatted):
> 
>   FAIL: grub_cmd_set_date
>   =======================

> Has anyone else seen this?

I just ran the build 5 times on my x86_64 machine, and it failed this
test 1/5 times.

We could try patching the test file with 'set -x' to trace the execution
of the script and see exactly what goes wrong.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: 01/02: gnu: qemu: Update to 2.9.0 [security fixes].

[Mark H Weaver]

[-- Attachment #1: Type: text/plain, Size: 936 bytes --]

Leo Famulari <leo@famulari.name> writes:

> On Thu, Apr 20, 2017 at 09:06:51PM -0400, Mark H Weaver wrote:
>> leo@famulari.name (Leo Famulari) writes:
>> >     gnu: qemu: Update to 2.9.0 [security fixes].
>> 
>> Thanks for this!  Obviously it's an important security update, but:
>> 
>> On my x86_64 system running GuixSD, 'grub' now fails to build from
>> source.  Three times in a row, the 'grub_cmd_set_date' has failed.
>> Here's the relevant excerpt from test-suite.log (lightly formatted):
>> 
>>   FAIL: grub_cmd_set_date
>>   =======================
>
>> Has anyone else seen this?
>
> I just ran the build 5 times on my x86_64 machine, and it failed this
> test 1/5 times.
>
> We could try patching the test file with 'set -x' to trace the execution
> of the script and see exactly what goes wrong.

Of course it would be good to investigate, but for now, here is the
patch that I used to disable that one test.

       Mark



[-- Attachment #2: [PATCH] DRAFT: gnu: grub: Disable failing test --]
[-- Type: text/x-patch, Size: 1598 bytes --]

From 3ea154ed0dff96c348a0ee5a3a45678fc8a1dfb5 Mon Sep 17 00:00:00 2001
From: Mark H Weaver <mhw@netris.org>
Date: Thu, 20 Apr 2017 21:14:45 -0400
Subject: [PATCH] DRAFT: gnu: grub: Disable failing test.

* gnu/packages/bootloaders.scm (grub)[arguments]: Add 'disable-failing-test'
phase.
---
 gnu/packages/bootloaders.scm | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/bootloaders.scm b/gnu/packages/bootloaders.scm
index 98afc6a7c..f495c39d7 100644
--- a/gnu/packages/bootloaders.scm
+++ b/gnu/packages/bootloaders.scm
@@ -1,6 +1,6 @@
 ;;; GNU Guix --- Functional package management for GNU
 ;;; Copyright © 2013, 2014, 2015, 2016, 2017 Ludovic Courtès <ludo@gnu.org>
-;;; Copyright © 2015 Mark H Weaver <mhw@netris.org>
+;;; Copyright © 2015, 2017 Mark H Weaver <mhw@netris.org>
 ;;; Copyright © 2015 Leo Famulari <leo@famulari.name>
 ;;; Copyright © 2016 Jan Nieuwenhuizen <janneke@gnu.org>
 ;;; Copyright © 2016, 2017 Marius Bakke <mbakke@fastmail.com>
@@ -95,7 +95,12 @@
                      ;; Make the font visible.
                      (copy-file (assoc-ref inputs "unifont") "unifont.bdf.gz")
                      (system* "gunzip" "unifont.bdf.gz")
-                     #t)))))
+                     #t))
+                  (add-before 'check 'disable-failing-test
+                    (lambda _
+                      (substitute* "Makefile"
+                        ((" grub_cmd_set_date ") " "))
+                      #t)))))
     (inputs
      `(("gettext" ,gettext-minimal)
 
-- 
2.12.2

Re: 01/02: gnu: qemu: Update to 2.9.0 [security fixes].

[Leo Famulari]

[-- Attachment #1: Type: text/plain, Size: 1121 bytes --]

On Fri, Apr 21, 2017 at 02:31:44PM -0400, Mark H Weaver wrote:
> Leo Famulari <leo@famulari.name> writes:
> > On Thu, Apr 20, 2017 at 09:06:51PM -0400, Mark H Weaver wrote:
> >>   FAIL: grub_cmd_set_date
> >>   =======================
> >
> >> Has anyone else seen this?
> >
> > I just ran the build 5 times on my x86_64 machine, and it failed this
> > test 1/5 times.
> >
> > We could try patching the test file with 'set -x' to trace the execution
> > of the script and see exactly what goes wrong.
> 
> Of course it would be good to investigate, but for now, here is the
> patch that I used to disable that one test.

> From 3ea154ed0dff96c348a0ee5a3a45678fc8a1dfb5 Mon Sep 17 00:00:00 2001
> From: Mark H Weaver <mhw@netris.org>
> Date: Thu, 20 Apr 2017 21:14:45 -0400
> Subject: [PATCH] DRAFT: gnu: grub: Disable failing test.
> 
> * gnu/packages/bootloaders.scm (grub)[arguments]: Add 'disable-failing-test'
> phase.

Okay, sounds good. Can you forward this report to <bug-grub@gnu.org>?

By the way, I'm testing the latest release of grub, 2.02~rc2, and this
test is flaky there, too.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]