From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40610) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d22Mz-0007tH-9m for guix-patches@gnu.org; Sat, 22 Apr 2017 17:15:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d22Mw-0007bi-Kd for guix-patches@gnu.org; Sat, 22 Apr 2017 17:15:05 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:36579) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1d22Mw-0007bY-Hm for guix-patches@gnu.org; Sat, 22 Apr 2017 17:15:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1d22Mw-000384-D4 for guix-patches@gnu.org; Sat, 22 Apr 2017 17:15:02 -0400 Subject: bug#26425: [PATCH 1/2] gnu: Add python-poppler-qt5. Resent-To: guix-patches@gnu.org Resent-Message-ID: References: <20170409204753.24456-1-rekado@elephly.net> <871st0hbhk.fsf@gnu.org> <87efwzqsg2.fsf@elephly.net> From: Ricardo Wurmus In-reply-to: <87efwzqsg2.fsf@elephly.net> Date: Sat, 22 Apr 2017 23:13:57 +0200 Message-ID: <8737d0taay.fsf@elephly.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: 26425-done@debbugs.gnu.org Ricardo Wurmus writes: > Ludovic Courtès writes: > >> Ricardo Wurmus skribis: >> >>> * gnu/packages/pdf.scm (python-poppler-qt5): New variable. >> >> LGTM! >> >>> + (substitute* "setup.py" >>> + ;; This check always fails, so disable it. >>> + (("if not check_qtxml\\(\\)") >>> + "if True") >> >> The check fails wrongfully? > > Yes. We do provide qtxml with qtbase. It’s easier to disable this > check than to fix it, given that we know that we have qtxml. I forgot to close this bug. This has been pushed to master with commit 99bcae94bcd50fc15bf44b5cc06cd39450f01ad5. -- Ricardo GPG: BCA6 89B6 3655 3801 C3C6 2150 197A 5888 235F ACAC https://elephly.net