From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42837) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d8QDv-00010O-LG for guix-patches@gnu.org; Wed, 10 May 2017 07:56:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d8QDr-0003kY-0R for guix-patches@gnu.org; Wed, 10 May 2017 07:56:07 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:60724) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1d8QDq-0003kU-UA for guix-patches@gnu.org; Wed, 10 May 2017 07:56:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1d8QDq-0005mD-O6 for guix-patches@gnu.org; Wed, 10 May 2017 07:56:02 -0400 Subject: bug#26669: [PATCH 1/7] gnu: Add cdrtools. Resent-Message-ID: From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) References: <20170426.180534.1677459693482729603.post@thomasdanckaert.be> <8760hit7tr.fsf@gnu.org> <20170510.094834.43521092439100471.post@thomasdanckaert.be> Date: Wed, 10 May 2017 13:55:13 +0200 In-Reply-To: <20170510.094834.43521092439100471.post@thomasdanckaert.be> (Thomas Danckaert's message of "Wed, 10 May 2017 09:48:34 +0200 (CEST)") Message-ID: <8737cdvsda.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Thomas Danckaert Cc: 26669@debbugs.gnu.org, 26669-close@debbugs.gnu.org Hi Thomas, Thomas Danckaert skribis: > Thanks for your comments. > > I pushed the series to master, with all comments addressed. Except > these 2 by Ludo, where I didn't really manage... > > From: ludo@gnu.org (Ludovic Court=C3=A8s) > Subject: Re: bug#26669: [PATCH 1/7] gnu: Add cdrtools. > Date: Wed, 03 May 2017 14:59:12 +0200 > >>> +++ b/gnu/packages/patches/cdrtools-3.01-mkisofs-isoinfo.patch >>> @@ -0,0 +1,514 @@ >>> +Patch for version 3.01, taken from upstream at >>> +https://sourceforge.net/projects/cdrtools/files/cdrtools-3.01-fix-2015= 1126-mkisofs-isoinfo.patch >> >> It would be nice to add a few words about what it does, like =E2=80=9CFix >> compilation with recent glibc=E2=80=9D or something. > > Unfortunately, I couldn't find a proper explanation for the patch, and > I'm not familiar enough with the cdrtools code base to completely > understand it myself. It seems like it fixes some issues and upgrades > half-way to 3.02 at the same time... Well at least we can get rid of > the patch if/when they release 3.02. OK, sounds reasonable. > From: ludo@gnu.org (Ludovic Court=C3=A8s) > Subject: Re: bug#26669: [PATCH 7/7] gnu: Add dvdstyler. > Date: Wed, 03 May 2017 15:04:47 +0200 > >>> + (arguments >>> + `(#:configure-flags (list (string-append "XMLTO=3D" >>> + (assoc-ref >>> %build-inputs "xmlto") >>> + "/bin/xmlto" >>> + " --searchpath " >>> + (assoc-ref >>> %build-inputs "docbook-xsl") >>> + >>> "/xml/xsl/docbook-xsl-1.79.1/htmlhelp:" >>> + (assoc-ref >>> %build-inputs "docbook-xml") >>> + "/xml/dtd/docbook")) >> >> I'd expect that adding libxml2 as an input would lead to the >> appropriate >> definition of XML_CATALOG_FILES, and thus remove the need for these >> #:configure-flags. Could you try that? > > I tried it, but it didn't work. Even with these flags, documentation > generation phase spits out a few warnings about attempted network > access to retrieve xsd files, but way less than without the flags, and > at html help is generated successfully :-) . Noted. Thanks! Ludo=E2=80=99.