all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: ludo@gnu.org (Ludovic Courtès)
To: 26829@debbugs.gnu.org
Subject: bug#26829: Add knot service
Date: Sun, 28 May 2017 19:34:06 +0200	[thread overview]
Message-ID: <8737bosx69.fsf@gnu.org> (raw)
In-Reply-To: <20170527104145.2d8b6867@lepiller.eu> (Julien Lepiller's message of "Sat, 27 May 2017 10:41:45 +0200")

Hi Julien,

Julien Lepiller <julien@lepiller.eu> skribis:

> So, pushed as ba69e8f7ce21a81bdd5b99fdb1cc64492443e15c.

Very nice and very useful notably for self-hosting use cases!

I have two minor comments:

  1. What it would it take to write tests for this?  I assume we could
     simply make DNS requests locally?

  2. For things like:

     +@item @code{nsec3-salt-lifetime} (default: @code{"30d"})

     I prefer using an integer denoting the number of seconds, and then
     letting users do the multiplication or use (string->duration "30d").
     I did that for ‘guix-publish-service’.

     Thoughts?

Thank you!

Ludo’.

  reply	other threads:[~2017-05-28 17:35 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-08 15:22 bug#26829: Add knot service Julien Lepiller
2017-05-08 18:25 ` Tobias Geerinckx-Rice
2017-05-08 18:27   ` Tobias Geerinckx-Rice
2017-05-22  7:57     ` julien lepiller
2017-05-27  8:41       ` Julien Lepiller
2017-05-28 17:34         ` Ludovic Courtès [this message]
2017-05-29  7:55           ` julien lepiller
2017-05-29 16:36             ` Ludovic Courtès
2017-05-31 19:41               ` Julien Lepiller
2017-05-31 21:17                 ` Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8737bosx69.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=26829@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.