[bug#27529] [PATCH] bootloader: Use <menu-entry> for the bootloader side.

[ludo@gnu.org (Ludovic Courtès)]

Danny Milosavljevic <dannym@scratchpost.org> skribis:

> * gnu/bootloader.scm (menu-entry-device-mount-point): New variable.  Export it.
> (<menu-entry>: New field "device".
> * gnu/bootloader/grub.scm (grub-confgiuration-file): Handle <menu-entry>
> entries.
> * gnu/bootloader/extlinux.scm (extlinux-configuration-file): Handle
> <menu-entry> entries.
> * gnu/system.scm (menu->entry->boot-parameters): Delete variable.
> (boot-parameters->menu-entry): New variable.  Export it.
> (operating-system-bootcfg): Make OLD-ENTRIES a list of <menu-entry>.
> * guix/script/system.scm (reinstall-bootloader):  Fix bootcfg usage.
> ---
>  gnu/bootloader.scm          |  3 +++
>  gnu/bootloader/extlinux.scm | 19 +++++++++----------
>  gnu/bootloader/grub.scm     | 27 ++++++++++++---------------
>  gnu/system.scm              | 29 ++++++++++++++---------------
>  guix/scripts/system.scm     | 10 +++++-----
>  5 files changed, 43 insertions(+), 45 deletions(-)

Could you explain the rationale?

IIRC there was the idea that implementations of the bootloader API
should use <boot-parameters>, and that <menu-entry> would be used only
in the user-facing APIs (it had even disappeared with the initial
thing.)

I don’t have anything against it at first sight but I just want to make
sure we don’t enter a loop.  :-)

Thanks,
Ludo’.