From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33082) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eOx9S-000534-2Q for guix-patches@gnu.org; Tue, 12 Dec 2017 21:52:07 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eOx9O-00033H-U3 for guix-patches@gnu.org; Tue, 12 Dec 2017 21:52:06 -0500 Received: from debbugs.gnu.org ([208.118.235.43]:50523) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eOx9O-000333-Kl for guix-patches@gnu.org; Tue, 12 Dec 2017 21:52:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eOx9O-0001LV-6S for guix-patches@gnu.org; Tue, 12 Dec 2017 21:52:02 -0500 Subject: [bug#29574] Fwd: [PATCH] Add Krita to guix Resent-Message-ID: From: Kei Kebreau References: <1512437757.2664676.1194102760.4CC1A193@webmail.messagingengine.com> <87609e1irt.fsf@posteo.net> <1512952158.106542.1200513048.7646AEF0@webmail.messagingengine.com> Date: Tue, 12 Dec 2017 21:51:00 -0500 In-Reply-To: <1512952158.106542.1200513048.7646AEF0@webmail.messagingengine.com> (Mark Meyer's message of "Mon, 11 Dec 2017 01:29:18 +0100") Message-ID: <87374f1gtn.fsf@posteo.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Mark Meyer Cc: 29574@debbugs.gnu.org --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Mark Meyer writes: > Hi Kei, > Poppler was an easy target, it just pointed to the wrong package. JPEG > requires some more packaging and EXR some thought. Meanwhile the > attached patch should be ok. > > Cheers, Mark > > On Sun, Dec 10, 2017, at 20:32, Kei Kebreau wrote: >> Mark Meyer writes: >>=20 >> > On Tue, Dec 5, 2017, at 02:26, Mark Meyer wrote: >> >> Second try. >> >>=20 >> >> I disabled all tests, since these required an X11 display to be prese= nt. >> >> It's running now. I created a new file and saved the output. Looks go= od. >> >>=20 >> >> Please find the patch attached. >> >>=20 >> >> Lints fine, but I didn't test if this is reproducible, since the build >> >> is taking a very long time (even with all tests disabled). >> >>=20 >> >> Cheers, Mark >> >>=20 >> >> --=20 >> >> Mark Meyer >> >> mark@ofosos.org >>=20 >> Hi Mark, >>=20 >> I built this package twice and it is reproducible! I've moved some >> inputs to native-inputs in the attached patch because they didn't show >> up as requisites for krita (i.e. I ran 'guix gc -R >> /gnu/store/...-krita-3.3.2.1' >> to find this out). >>=20 >> Please tell me if this build works properly for you as it seems to for >> me. >>=20 >> Thanks, >> Kei >>=20 >> Email had 2 attachments: >> + 0001-gnu-Add-krita.patch >> 5k (text/plain) >> + signature.asc >> 1k (application/pgp-signature) Great, LGTM. I added some detail to the description and pushed it to master= , so you can close this bug. Also, please be sure to follow our change log conventions, which are something like these[0]. When in doubt, copy from a recent change log for a change similar to yours from our repo. Most of the time this works without a problem. Thanks, Kei [0]: https://www.gnu.org/prep/standards/html_node/Style-of-Change-Logs.html --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEg7ZwOtzKO2lLzi2m5qXuPBlGeg0FAlowlZQACgkQ5qXuPBlG eg0ZnxAAuwxjp6hTkjhlIeedjVj52lDQTWnR9xrL0M77MqP3wUwhdKIgvdjsl4TE JYInw5fqwc1v31ILmGpp+gxbBVl/m3pJejkE8QSY9SL7qHSQUjR81Tdnji4YqtBK sVc6lg2+M6/IVIlanGUky7CBgXcvZlKurm0LM1hNGU2Hoy921jP2pcPOGP24hwfd 1N1OY4IA0qRppjBgYh9owAaXu7AvBpDqM+YGp3Ie/7zCi2OiA+UkEM6ZFyhZ9yPA qU8FzVog4dGheEPlcB4fLRLa7n/EF+ETM92sPMoWE8w6iNBd0CyJe8bkV2l2XqOR qo909za0QaILqw04BlZ26oTIecPUNDaqIaG4kSDtDSUqR0mSjiQN8ZzWrKs+OiCZ MpP3RfgnBlkiYPA24IK3O9UNK/iySeGkv0BOkiQs3exrZt8mgNtjh85KaGO4ou2/ DocuBXYKsj/ArI0NCyfP5gRy4nhiXF/Fe8ooW5Br7i1kgN3Q0qHyAqpSN0MTNo7P 6YrseLbOZldKdEAeSc4ABJrzmKrbs4r7VX+iD6reNY4qYiS1Btd0B85cOd6yPvfK aU8CTYFAKQQRGtjt7TFfSaJ9plWoMX4YsMgbZLnzYbWWfKr8V66zj3Mbzg21DZr4 2SLc/zO84scA97cdU86ITEYb4jhVSKbg1Jow3wnmM2iTNju9GC8= =XTk0 -----END PGP SIGNATURE----- --=-=-=--