From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52703) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1er5Js-0004li-Hv for guix-patches@gnu.org; Wed, 28 Feb 2018 12:15:10 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1er5Jm-0005Jk-GK for guix-patches@gnu.org; Wed, 28 Feb 2018 12:15:08 -0500 Received: from debbugs.gnu.org ([208.118.235.43]:58077) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1er5Jm-0005J3-9N for guix-patches@gnu.org; Wed, 28 Feb 2018 12:15:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1er5Jl-0003QS-SE for guix-patches@gnu.org; Wed, 28 Feb 2018 12:15:01 -0500 Subject: [bug#28004] Chromium Resent-Message-ID: From: Marius Bakke In-Reply-To: <20180227221711.omdpbgemrjwinohb@abyayala> References: <20180104191648.custe7w3l57fvbac@abyayala> <87wp0s2ewl.fsf@fastmail.com> <20180108232042.nqjurjr2bcfl2yyc@abyayala> <87373cey5b.fsf@fastmail.com> <87vag16g5z.fsf@gnu.org> <87fu75aar5.fsf@fastmail.com> <874lnkr0vf.fsf@gnu.org> <87vaejvclc.fsf@fastmail.com> <20180226200133.zsnahblbgzovrtmu@abyayala> <87muzvv7ku.fsf@fastmail.com> <20180227221711.omdpbgemrjwinohb@abyayala> Date: Wed, 28 Feb 2018 18:14:08 +0100 Message-ID: <87371lujdr.fsf@fastmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: ng0 Cc: 28004@debbugs.gnu.org --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable ng0 writes: > Marius Bakke transcribed 43K bytes: >> ng0 writes: >>=20 >> > Marius Bakke transcribed 2.1K bytes: >> >> Mike Gerwitz writes: >> >>=20 >> >> > On Tue, Jan 16, 2018 at 20:01:34 +0100, Marius Bakke wrote: >> >> >> If there are no objections, expect to see this in 'master' in 1-2 = weeks. >> >> > >> >> > I want to express gratitude for your hard work on this---given that >> >> > IceCat does not contain many of the FF devtool updates, Chromium is= very >> >> > desirable for web development. It's also needed for certain Node.js >> >> > tools, like node-inspector. >> >> > >> >> > So, thank you! >> >>=20 >> >> Thank *you* for the kind words! :-) >> >>=20 >> >> Here is the latest iteration of this patch. New in this version: >> >>=20 >> >> * Chromium 64 (duh). >> >> * The 'delete-bundled-software' phase has been moved to a snippet, >> >> shaving ~100MiB (~22%) off the compressed tarball size (and >> >> drastically reduces (de)compression time). >> >> * The New Tab page does not show any thumbnails for new profiles. >> > >> > I think you forgot to attach the patches :) >>=20 >> Derp. I realized that and just used `git send-email`[0], but have >> attached it here for convenience since the debbugs web UI doesn't allow >> easy download of a raw message. >>=20 >> [0] https://debbugs.gnu.org/cgi/bugreport.cgi?msg=3D131;bug=3D28004#131 >> > > Comments inlined, some words ahead. > > I think it's good that we will be able to handle extensions via Guix. > But: We should point it out that you won't be able to install extensions > manually, via the store or as a file. People who betatested this got > confused. I haven't tested installing from a file. Which error are you getting? You can use extensions from the store by setting the variable "CHROMIUM_ENABLE_WEB_STORE", as in Debian. But I don't see a need to document it since it's unsupported territory from a Guix viewpoint. >> + (substitute* "chrome/common/chrome_paths.cc" >> + (("/usr/share/chromium/extensions") >> + ;; TODO: Add ~/.guix-profile. >> + "/run/current-system/profile/share/chromium/extensions"= )) > > I don't know if I asked you about this in the past, bu= t can you explain why you > picked the run dir? I have to re-read the Gentoo eclas= s and Nix integration for this. The plan is to package extensions with Guix and place them in "out/share/chromium/extensions". Then you would be able to install extensions through the system profile, until a better solution is in place (like a search path). >> + (mkdir-p bin) >> + ;; Add a thin wrapper to prevent the user from inadver= tently >> + ;; installing non-free software through the Web Store. >> + ;; TODO: Discover extensions from the profile and pass >> + ;; something like "--disable-extensions-except=3D...". > > To be able to work on this, can you (at least in this= bug ticket, > explain the TODO part a bit more? This was inspired by Debians wrapper script, which discovers extensions installed by Apt and composes this command line. It allows disabling the web store while still using extensions. I'll see if I can improve the comment. Thanks for the feedback! --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAlqW42AACgkQoqBt8qM6 VPpRnggAmE+MC7xBreY8GO/9yNrpRVG0PmbEFR8PD35yuxffA2p+yI4y3oCPB5Zb 1Qd96cW5GgViyYnHHlIy1Ljct98hqo7mFP8+Sedoyzp546Ol2dPYAXVf0fw+YX65 AZu9Mf2OYanye+lQAmgHookcjHyleym1mCxFIEYdiJqVqeiL1mCKS2C59AwPt97s k+jbiRJLZUeLbk9PN9fP8Wbi86WuO0poTpi6veamvFt3Irbn8jrmC2j+D0xS8J4C JzvkfDgCpT0lcYifO3vcUP23CqmVs74iMMEtz3k0V9ZU/mljeoCoZOQizZSvaHC9 nSwOHjh82/b0cjSLnrr0b7dDCWbZRQ== =/dbz -----END PGP SIGNATURE----- --=-=-=--