From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46772)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1esFBL-0006Ol-Ky
	for guix-patches@gnu.org; Sat, 03 Mar 2018 16:59:08 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1esFBG-0003MC-OC
	for guix-patches@gnu.org; Sat, 03 Mar 2018 16:59:07 -0500
Received: from debbugs.gnu.org ([208.118.235.43]:35333)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1esFBG-0003M8-Js
	for guix-patches@gnu.org; Sat, 03 Mar 2018 16:59:02 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1esFBF-0006fP-Rg
	for guix-patches@gnu.org; Sat, 03 Mar 2018 16:59:02 -0500
Subject: [bug#30604] [PATCH v8 1/7] linux-modules: Add module-aliases.
Resent-Message-ID: <handler.30604.B30604.152011432025599@debbugs.gnu.org>
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
References: <20180302153408.14091-1-dannym@scratchpost.org>
	<20180303135533.6112-1-dannym@scratchpost.org>
	<20180303135533.6112-2-dannym@scratchpost.org>
Date: Sat, 03 Mar 2018 22:58:36 +0100
In-Reply-To: <20180303135533.6112-2-dannym@scratchpost.org> (Danny
	Milosavljevic's message of "Sat, 3 Mar 2018 14:55:27 +0100")
Message-ID: <87371g6ctv.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Danny Milosavljevic <dannym@scratchpost.org>
Cc: 30604@debbugs.gnu.org

Danny Milosavljevic <dannym@scratchpost.org> skribis:

> * gnu/build/linux-modules.scm (module-aliases): New variable.

LGTM!

> +(define (module-aliases file)
> +  "Return the list of aliases of module FILE."
> +  (let ((info (modinfo-section-contents file)))
> +    (filter-map (match-lambda
> +                 (('alias . value)
> +                  value)
> +                 (_ #f)) (modinfo-section-contents file))))

Nitpick: align like this:

  (filter-map first
              second)

when the first arg spans several lines.